Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: virtio@lists.oasis-open.org,
	Christophe de Dinechin <cdupontd@redhat.com>
Subject: [virtio] [PATCH v2] virtio_pci_cap64: bar/BAR cleanups
Date: Wed, 27 Nov 2019 16:33:07 -0500	[thread overview]
Message-ID: <20191127213240.34106-1-mst@redhat.com> (raw)

When we mean PCI register we should say BAR.
When we mean a virtio config register we should say \field{cap.bar}.

Finally, offset_hi/length_hi are not within the cap structure.

Tweak wording slightly: "A,B,C" are fields, there's no need
to say that.

Reported-by: Christophe de Dinechin <cdupontd@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

changes from v1:
	minor wording tweak

 content.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/content.tex b/content.tex
index f808c61..a7f4f27 100644
--- a/content.tex
+++ b/content.tex
@@ -765,7 +765,7 @@ \subsection{Virtio Structure PCI Capabilities}\label{sec:Virtio Transport Option
 Given that the \field{cap.length} and \field{cap.offset} fields
 are only 32 bit, the additional \field{offset_hi} and \field {length_hi}
 fields provide the most significant 32 bits of a total 64 bit offset and
-length within the bar specified by \field{cap.bar}.
+length within the BAR specified by \field{cap.bar}.
 
 \drivernormative{\subsubsection}{Virtio Structure PCI Capabilities}{Virtio Transport Options / Virtio Over PCI Bus / Virtio Structure PCI Capabilities}
 
@@ -1095,9 +1095,9 @@ \subsubsection{Shared memory capability}\label{sec:Virtio Transport Options / Vi
 
 \devicenormative{\paragraph}{Device-specific configuration}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Shared memory capability}
 
-The region defined by the combination of the \field {cap.offset},
-\field {cap.offset_hi}, and \field {cap.length}, \field
-{cap.length_hi} fields MUST be contained within the declared bar.
+The region defined by the combination of \field{cap.offset},
+\field{offset_hi}, and \field {cap.length}, \field{length_hi}
+MUST be contained within the BAR specified by \field{cap.bar}.
 
 The \field{cap.id} MUST be unique for any one device instance.
 
-- 
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


             reply	other threads:[~2019-11-27 21:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 21:33 Michael S. Tsirkin [this message]
2019-11-28 16:54 ` [virtio] [PATCH v2] virtio_pci_cap64: bar/BAR cleanups Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127213240.34106-1-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=cdupontd@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox