From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, virtio@lists.oasis-open.org,
Christophe de Dinechin <cdupontd@redhat.com>
Subject: Re: [virtio] [PATCH v2] virtio_pci_cap64: bar/BAR cleanups
Date: Thu, 28 Nov 2019 17:54:59 +0100 [thread overview]
Message-ID: <20191128175459.1888efdc.cohuck@redhat.com> (raw)
In-Reply-To: <20191127213240.34106-1-mst@redhat.com>
On Wed, 27 Nov 2019 16:33:07 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> When we mean PCI register we should say BAR.
> When we mean a virtio config register we should say \field{cap.bar}.
>
> Finally, offset_hi/length_hi are not within the cap structure.
>
> Tweak wording slightly: "A,B,C" are fields, there's no need
> to say that.
>
> Reported-by: Christophe de Dinechin <cdupontd@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> changes from v1:
> minor wording tweak
>
> content.tex | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
prev parent reply other threads:[~2019-11-28 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 21:33 [virtio] [PATCH v2] virtio_pci_cap64: bar/BAR cleanups Michael S. Tsirkin
2019-11-28 16:54 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128175459.1888efdc.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=cdupontd@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox