From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Zha Bin <zhabin@linux.alibaba.com>,
virtio-dev@lists.oasis-open.org, slp@redhat.com,
jing2.liu@linux.intel.com, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, chao.p.peng@linux.intel.com,
gerry@linux.alibaba.com
Subject: [virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue
Date: Wed, 12 Feb 2020 03:18:57 -0500 [thread overview]
Message-ID: <20200212024158-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ef613d3a-0372-64f3-7644-2e88cc9d4355@redhat.com>
On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote:
>
> On 2020/2/11 下午7:33, Michael S. Tsirkin wrote:
> > On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote:
> > > From: Liu Jiang<gerry@linux.alibaba.com>
> > >
> > > The standard virtio-mmio devices use notification register to signal
> > > backend. This will cause vmexits and slow down the performance when we
> > > passthrough the virtio-mmio devices to guest virtual machines.
> > > We proposed to update virtio over MMIO spec to add the per-queue
> > > notify feature VIRTIO_F_MMIO_NOTIFICATION[1]. It can allow the VMM to
> > > configure notify location for each queue.
> > >
> > > [1]https://lkml.org/lkml/2020/1/21/31
> > >
> > > Signed-off-by: Liu Jiang<gerry@linux.alibaba.com>
> > > Co-developed-by: Zha Bin<zhabin@linux.alibaba.com>
> > > Signed-off-by: Zha Bin<zhabin@linux.alibaba.com>
> > > Co-developed-by: Jing Liu<jing2.liu@linux.intel.com>
> > > Signed-off-by: Jing Liu<jing2.liu@linux.intel.com>
> > > Co-developed-by: Chao Peng<chao.p.peng@linux.intel.com>
> > > Signed-off-by: Chao Peng<chao.p.peng@linux.intel.com>
> > Hmm. Any way to make this static so we don't need
> > base and multiplier?
>
>
> E.g page per vq?
>
> Thanks
Problem is, is page size well defined enough?
Are there cases where guest and host page sizes differ?
I suspect there might be.
But I also think this whole patch is unproven. Is someone actually
working on QEMU code to support pass-trough of virtio-pci
as virtio-mmio for nested guests? What's the performance
gain like?
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2020-02-12 8:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1581305609.git.zhabin@linux.alibaba.com>
2020-02-10 11:44 ` [virtio-dev] Re: [PATCH v2 0/5] virtio mmio specification enhancement Michael S. Tsirkin
[not found] ` <20200211160541.GA37446@chaop.bj.intel.com>
2020-02-11 10:57 ` Michael S. Tsirkin
[not found] ` <4c3d13be5a391b1fc50416838de57d903cbf8038.1581305609.git.zhabin@linux.alibaba.com>
2020-02-11 3:17 ` [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support Jason Wang
2020-02-11 3:35 ` Liu, Jing2
2020-02-11 4:02 ` Jason Wang
2020-02-11 6:02 ` Liu, Jing2
2020-02-11 7:40 ` Jason Wang
2020-02-11 11:58 ` Michael S. Tsirkin
2020-02-11 12:04 ` Jason Wang
2020-02-11 12:08 ` Michael S. Tsirkin
2020-02-11 12:18 ` Jason Wang
2020-02-11 14:00 ` Michael S. Tsirkin
2020-02-12 9:03 ` Jason Wang
2020-02-12 9:15 ` Michael S. Tsirkin
2020-02-12 3:54 ` Liu, Jing2
2020-02-12 7:33 ` Michael S. Tsirkin
2020-02-12 9:06 ` Jason Wang
2020-02-12 9:16 ` Michael S. Tsirkin
2020-02-13 3:40 ` Jason Wang
2020-02-11 11:21 ` Michael S. Tsirkin
2020-02-11 11:11 ` Michael S. Tsirkin
[not found] ` <946b71e77a34666a9b8c419c5a467d1628b50fa0.1581305609.git.zhabin@linux.alibaba.com>
2020-02-11 11:14 ` [virtio-dev] Re: [PATCH v2 5/5] x86: virtio-mmio: support virtio-mmio with MSI for x86 Michael S. Tsirkin
[not found] ` <0268807dc26ecdf5620de9000758d05ca0b21f3f.1581305609.git.zhabin@linux.alibaba.com>
2020-02-11 11:19 ` [virtio-dev] Re: [PATCH v2 2/5] virtio-mmio: refactor common functionality Michael S. Tsirkin
2020-02-12 2:58 ` Liu, Jing2
2020-02-12 7:29 ` Michael S. Tsirkin
[not found] ` <8a4ea95d6d77a2814aaf6897b5517353289a098e.1581305609.git.zhabin@linux.alibaba.com>
2020-02-11 10:50 ` [virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue Michael S. Tsirkin
2020-02-11 11:33 ` Michael S. Tsirkin
2020-02-12 3:39 ` Jason Wang
2020-02-12 8:18 ` Michael S. Tsirkin [this message]
2020-02-12 8:53 ` Jason Wang
2020-02-12 9:33 ` Jason Wang
2020-02-12 9:55 ` Michael S. Tsirkin
2020-02-13 3:38 ` Jason Wang
[not found] ` <4c52548758eefe1fe7078d3b6f10492a001c0636.1581305609.git.zhabin@linux.alibaba.com>
2020-02-11 11:16 ` [virtio-dev] Re: [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain Michael S. Tsirkin
2020-02-12 7:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212024158-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=gerry@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=jing2.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=zhabin@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox