From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-6743-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id B4C63985DD2 for ; Wed, 12 Feb 2020 09:15:10 +0000 (UTC) Date: Wed, 12 Feb 2020 04:15:01 -0500 From: "Michael S. Tsirkin" Message-ID: <20200212041317-mutt-send-email-mst@kernel.org> References: <5522f205-207b-b012-6631-3cc77dde3bfe@linux.intel.com> <45e22435-08d3-08fe-8843-d8db02fcb8e3@redhat.com> <20200211065319-mutt-send-email-mst@kernel.org> <20200211070523-mutt-send-email-mst@kernel.org> <20200211090003-mutt-send-email-mst@kernel.org> <4557a5e8-74eb-f238-1579-b7b558cb2969@redhat.com> MIME-Version: 1.0 In-Reply-To: <4557a5e8-74eb-f238-1579-b7b558cb2969@redhat.com> Subject: Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: Jason Wang Cc: virtio-dev@lists.oasis-open.org, Zha Bin , slp@redhat.com, "Liu, Jing2" , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, chao.p.peng@linux.intel.com, gerry@linux.alibaba.com List-ID: On Wed, Feb 12, 2020 at 05:03:00PM +0800, Jason Wang wrote: >=20 > On 2020/2/11 =E4=B8=8B=E5=8D=8810:00, Michael S. Tsirkin wrote: > > > Yes, it can work but it may bring extra effort when you want to mask = a > > > vector which is was shared by a lot of queues. > > >=20 > > > Thanks > > >=20 > > masking should be per vq too. > >=20 > > --=20 >=20 >=20 > Yes, but if the vector is shard by e.g 16 queues, then all those virtqueu= es > needs to be masked which is expensive. >=20 > Thanks I think that's ok - masking is rare. in fact if vectors can be changed atomically I'm no longer sure they are needed, maybe a destructive "disable" which can lose interrupts is enough. --=20 MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org