Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: virtio-dev@lists.oasis-open.org, mst@redhat.com
Subject: [virtio-dev] Re: [PATCH] virtio-iommu: Remove invalid requirement about padding
Date: Mon, 23 Mar 2020 15:09:26 +0100	[thread overview]
Message-ID: <20200323150926.18b438de.cohuck@redhat.com> (raw)
In-Reply-To: <20200323132021.2108049-1-jean-philippe@linaro.org>

On Mon, 23 Mar 2020 14:20:22 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> This reference to 'padding' is a leftover from a previous draft of the
> virtio-iommu device. The field doesn't exist anymore, remove the
> requirement.
> 
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> I just noticed this was still here, sorry for the delay. Previous
> discussion:
> https://lists.oasis-open.org/archives/virtio-dev/201911/msg00084.html
> ---
>  virtio-iommu.tex | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/virtio-iommu.tex b/virtio-iommu.tex
> index 28c562b..08b358a 100644
> --- a/virtio-iommu.tex
> +++ b/virtio-iommu.tex
> @@ -106,8 +106,6 @@ \subsection{Device configuration layout}\label{sec:Device Types / IOMMU Device /
>  
>  \devicenormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
>  
> -The device SHOULD set \field{padding} to zero.
> -
>  The device MUST set at least one bit in \field{page_size_mask}, describing
>  the page granularity. The device MAY set more than one bit in
>  \field{page_size_mask}.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


      parent reply	other threads:[~2020-03-23 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 13:20 [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding Jean-Philippe Brucker
2020-03-23 13:56 ` Auger Eric
2020-03-23 14:09 ` Cornelia Huck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323150926.18b438de.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=mst@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox