* [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding
@ 2020-03-23 13:20 Jean-Philippe Brucker
2020-03-23 13:56 ` Auger Eric
2020-03-23 14:09 ` [virtio-dev] " Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Jean-Philippe Brucker @ 2020-03-23 13:20 UTC (permalink / raw)
To: virtio-dev; +Cc: mst, cohuck, Jean-Philippe Brucker
This reference to 'padding' is a leftover from a previous draft of the
virtio-iommu device. The field doesn't exist anymore, remove the
requirement.
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
I just noticed this was still here, sorry for the delay. Previous
discussion:
https://lists.oasis-open.org/archives/virtio-dev/201911/msg00084.html
---
virtio-iommu.tex | 2 --
1 file changed, 2 deletions(-)
diff --git a/virtio-iommu.tex b/virtio-iommu.tex
index 28c562b..08b358a 100644
--- a/virtio-iommu.tex
+++ b/virtio-iommu.tex
@@ -106,8 +106,6 @@ \subsection{Device configuration layout}\label{sec:Device Types / IOMMU Device /
\devicenormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
-The device SHOULD set \field{padding} to zero.
-
The device MUST set at least one bit in \field{page_size_mask}, describing
the page granularity. The device MAY set more than one bit in
\field{page_size_mask}.
--
2.25.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding
2020-03-23 13:20 [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding Jean-Philippe Brucker
@ 2020-03-23 13:56 ` Auger Eric
2020-03-23 14:09 ` [virtio-dev] " Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Auger Eric @ 2020-03-23 13:56 UTC (permalink / raw)
To: Jean-Philippe Brucker, virtio-dev; +Cc: mst, cohuck
Hi jean,
On 3/23/20 2:20 PM, Jean-Philippe Brucker wrote:
> This reference to 'padding' is a leftover from a previous draft of the
> virtio-iommu device. The field doesn't exist anymore, remove the
> requirement.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> I just noticed this was still here, sorry for the delay. Previous
> discussion:
> https://lists.oasis-open.org/archives/virtio-dev/201911/msg00084.html
> ---
> virtio-iommu.tex | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/virtio-iommu.tex b/virtio-iommu.tex
> index 28c562b..08b358a 100644
> --- a/virtio-iommu.tex
> +++ b/virtio-iommu.tex
> @@ -106,8 +106,6 @@ \subsection{Device configuration layout}\label{sec:Device Types / IOMMU Device /
>
> \devicenormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
>
> -The device SHOULD set \field{padding} to zero.
> -
> The device MUST set at least one bit in \field{page_size_mask}, describing
> the page granularity. The device MAY set more than one bit in
> \field{page_size_mask}.
>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [virtio-dev] Re: [PATCH] virtio-iommu: Remove invalid requirement about padding
2020-03-23 13:20 [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding Jean-Philippe Brucker
2020-03-23 13:56 ` Auger Eric
@ 2020-03-23 14:09 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2020-03-23 14:09 UTC (permalink / raw)
To: Jean-Philippe Brucker; +Cc: virtio-dev, mst
On Mon, 23 Mar 2020 14:20:22 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
> This reference to 'padding' is a leftover from a previous draft of the
> virtio-iommu device. The field doesn't exist anymore, remove the
> requirement.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> I just noticed this was still here, sorry for the delay. Previous
> discussion:
> https://lists.oasis-open.org/archives/virtio-dev/201911/msg00084.html
> ---
> virtio-iommu.tex | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/virtio-iommu.tex b/virtio-iommu.tex
> index 28c562b..08b358a 100644
> --- a/virtio-iommu.tex
> +++ b/virtio-iommu.tex
> @@ -106,8 +106,6 @@ \subsection{Device configuration layout}\label{sec:Device Types / IOMMU Device /
>
> \devicenormative{\subsubsection}{Device configuration layout}{Device Types / IOMMU Device / Device configuration layout}
>
> -The device SHOULD set \field{padding} to zero.
> -
> The device MUST set at least one bit in \field{page_size_mask}, describing
> the page granularity. The device MAY set more than one bit in
> \field{page_size_mask}.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-23 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-23 13:20 [virtio-dev] [PATCH] virtio-iommu: Remove invalid requirement about padding Jean-Philippe Brucker
2020-03-23 13:56 ` Auger Eric
2020-03-23 14:09 ` [virtio-dev] " Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox