From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-7609-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EE70D985DD1 for ; Thu, 23 Jul 2020 03:59:58 +0000 (UTC) Date: Wed, 22 Jul 2020 23:59:50 -0400 From: "Michael S. Tsirkin" Message-ID: <20200722235758-mutt-send-email-mst@kernel.org> References: <20200629080615.26022-1-david@redhat.com> <20200722080356-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Subject: [virtio-dev] Re: [PATCH v2] virtio-balloon: always indicate S_DONE when migration fails Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: David Hildenbrand Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, Alexander Duyck , Wei Wang , Alexander Duyck List-ID: On Wed, Jul 22, 2020 at 02:05:19PM +0200, David Hildenbrand wrote: > On 22.07.20 14:04, Michael S. Tsirkin wrote: > > On Mon, Jun 29, 2020 at 10:06:15AM +0200, David Hildenbrand wrote: > >> If something goes wrong during precopy, before stopping the VM, we will > >> never send a S_DONE indication to the VM, resulting in the hinted pages > >> not getting released to be used by the guest OS (e.g., Linux). > >> > >> Easy to reproduce: > >> 1. Start migration (e.g., HMP "migrate -d 'exec:gzip -c > STATEFILE.gz'") > >> 2. Cancel migration (e.g., HMP "migrate_cancel") > >> 3. Oberve in the guest (e.g., cat /proc/meminfo) that there is basically > >> no free memory left. > >> > >> While at it, add similar locking to virtio_balloon_free_page_done() as > >> done in virtio_balloon_free_page_stop. Locking is still weird, but that > >> has to be sorted out separately. > >> > >> There is nothing to do in the PRECOPY_NOTIFY_COMPLETE case. Add some > >> comments regarding S_DONE handling. > >> > >> Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") > >> Reviewed-by: Alexander Duyck > >> Cc: Wei Wang > >> Cc: Alexander Duyck > >> Signed-off-by: David Hildenbrand > > > > IIUC this is superceded by Alexander's patches right? > > Not that I know ... @Alex? > > > If not pls rebase ... > > OK then I guess I was confused. This is older so I guess I should have applied this and asked Alex to rebase his patches, but I did the reverse.., Sorry about that. Could you rebase on top of the pci tree pls? Thanks and sorry for messing up. > > > -- > Thanks, > > David / dhildenb --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org