Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	virtio-comment@lists.oasis-open.org,
	virtio-dev@lists.oasis-open.org, "Wang,
	Wei W" <wei.w.wang@intel.com>
Subject: [virtio-comment] Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features
Date: Tue, 1 Sep 2020 10:34:40 -0400	[thread overview]
Message-ID: <20200901103356-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAKgT0Uc12p_Y3UKFA6=66ecEjOaGhfQ=gb--nf2HA2iLap7KvA@mail.gmail.com>

On Tue, Aug 25, 2020 at 01:40:25PM -0700, Alexander Duyck wrote:
> On Tue, Aug 25, 2020 at 8:01 AM Cornelia Huck <cohuck@redhat.com> wrote:
> >
> > On Tue, 25 Aug 2020 07:44:55 -0700
> > Alexander Duyck <alexander.duyck@gmail.com> wrote:
> >
> > > This patch set is meant to add documentation for balloon features that have
> > > been recently added to the Linux kernel[1,2] and that were recently added
> > > to QEMU[3].
> > >
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84
> > >
> > > Changes since RFC:
> > > Incorporated suggestions from Cornelia Huck
> > > Fixed a few additional spelling errors
> > >
> > > Changes since v1:
> > > Incorporated additional suggestions from Cornelia Huck
> > > Dropped documentation referring to free page reporting from page poison patch
> > >
> > > Changes since v2:
> > > Rewrote multiple statements based on input from David Hildenbrand
> > >   Dropped use of balloon and deflate from page hinting description
> > >   Dropped use of free page reporting from page poison description
> > >   Cleaned up several spots that didn't match RFC2119 style comments
> > >   Added conformance links.
> > >   Various other clean-ups.
> > > Updated balloon command IDs based on input from Cornelia Huck
> > >
> > > Changes since v3:
> > > Reordered patches to place free page hinting at end of patch set
> > >   Moved contents out of patch to poison and free page reporting patches
> > >   Updated patch description to document some known issues with feature
> > > Further clean-ups based on input from David Hildenbrand
> > >
> > > Changes since v4:
> > > Further clean-ups for page hinting based on input from David Hildenbrand
> > >
> > > Changes since v5:
> > > Reverted patcher order changes from v3 placing hinting as first patch
> > > Addressed comments and added Reviewed-by from Cornelia Huck
> > > Addressed further items I found in free page hinting
> > >   Added requirement that output buffers be 4 bytes in size
> > >   Replaced reference to descriptor with buffer
> > >   Replaced references to free_page_hint_vq with free_page_vq
> > >
> > > Changes since v6:
> > > Fixed line that was left over from a merge conflict
> > > Added Reviewed-by from David Hildenbrand
> > > Created issue and added "Fixes" to cover page
> > >
> > > Changes since v7:
> > > Removed comments from patch 1 describing issues that we fixed or addressed
> > > Added Acked-by for patch 1 from Cornelia Huck
> > >
> > > [1]: https://lore.kernel.org/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/
> > > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc
> > > [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html
> > >
> > > ---
> > >
> > > Alexander Duyck (3):
> > >       content: Document balloon feature free page hints
> > >       content: Document balloon feature page poison
> > >       content: Document balloon feature free page reporting
> > >
> > >
> > >  conformance.tex |    6 +
> > >  content.tex     |  286 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > >  2 files changed, 286 insertions(+), 6 deletions(-)
> > >
> > > --
> > >
> >
> > I think this is good to vote on now.
> 
> Thanks for the review feedback. If there are no other comments then I
> request a vote for inclusion.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/84
> 
> - Alex

Ballot created at https://www.oasis-open.org/committees/ballot.php?id=3521
Once it concludes, would appreciate a reminder to merge the patch.
Thanks!

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  reply	other threads:[~2020-09-01 14:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 14:44 [virtio-comment] [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features Alexander Duyck
2020-08-25 14:45 ` [virtio-comment] [PATCH v8 1/3] content: Document balloon feature free page hints Alexander Duyck
2020-09-04 15:19   ` [virtio-comment] Re: [virtio-dev] " Jan Kiszka
2020-09-04 16:56     ` Alexander Duyck
2020-09-11  5:28       ` Jan Kiszka
2020-09-11 15:11         ` Alexander Duyck
2020-09-14  6:13           ` Cornelia Huck
2020-09-14 19:44             ` [virtio-comment] [PATCH v8 4/3] content: Minor change to clarify free_page_hint_cmd_id Alexander Duyck
2020-09-15  6:56               ` [virtio-comment] " Cornelia Huck
2020-09-16 13:28             ` [virtio-comment] Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints Michael S. Tsirkin
2020-11-11 18:03               ` Cornelia Huck
2020-11-11 22:09                 ` Alexander Duyck
2020-11-12  7:45                   ` Cornelia Huck
2020-11-12 22:58                     ` Alexander Duyck
2020-08-25 14:45 ` [virtio-comment] [PATCH v8 2/3] content: Document balloon feature page poison Alexander Duyck
2020-08-25 14:45 ` [virtio-comment] [PATCH v8 3/3] content: Document balloon feature free page reporting Alexander Duyck
2020-08-25 15:01 ` [virtio-comment] Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features Cornelia Huck
2020-08-25 20:40   ` Alexander Duyck
2020-09-01 14:34     ` Michael S. Tsirkin [this message]
2020-09-10 14:50       ` Alexander Duyck
2020-09-10 15:05         ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901103356-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alexander.duyck@gmail.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox