Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jie Deng <jie.deng@intel.com>
Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Subject: [virtio-comment] Re: [virtio-dev] Re: [PATCH v2] virtio-i2c: add the device specification
Date: Tue, 27 Oct 2020 07:20:24 -0400	[thread overview]
Message-ID: <20201027071957-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <a4a8ee83-d3e6-df1f-c0ac-f608d563522e@intel.com>

On Mon, Oct 26, 2020 at 09:22:07AM +0800, Jie Deng wrote:
> On 2020/10/24 0:00, Michael S. Tsirkin wrote:
> 
> > On Fri, Oct 23, 2020 at 02:51:25PM +0800, Jie Deng wrote:
> > > +
> > > +The driver queues requests to the virtqueues, and they are used by the
> > > +device. The request is the representation of one segment of an I2C
> > > +transaction. Each request is of form:
> > > +
> > > +\begin{lstlisting}
> > > +struct virtio_i2c_req {
> > > +        le16 addr;
> > > +        le16 flags;
> > > +        le16 len;
> > > +        u8 buf[];
> > > +        u8 status;
> > > +};
> > > +\end{lstlisting}
> > > +
> > > +The \field{addr} is the address of the I2C slave device.
> > > +
> > > +The first bit of \field{flags} indicates whether it is a read or write request.
> > > +It means a read request if the first bit of \field{flags} is set, otherwise
> > > +it is a write request. The rest bits of \field{flags} are reserved.
> > > 
> > 
> > So how does one creates a multi-segment transaction then?
> > 
> The I2C doesn't support segments numbering and sorting.
> So if one creates a multi-segment transaction, then he/she should keep the
> segments in order.
> 
> Thanks.

Fine, but I see no flags to signal start/end of such a transaction.

> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> > 


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2020-10-27 11:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  6:51 [virtio-comment] [PATCH v2] virtio-i2c: add the device specification Jie Deng
2020-10-23 16:00 ` [virtio-comment] " Michael S. Tsirkin
2020-10-26  1:22   ` [virtio-comment] Re: [virtio-dev] " Jie Deng
2020-10-26  8:08     ` [virtio-comment] " Jie Deng
2020-10-27 11:20     ` Michael S. Tsirkin [this message]
2020-10-31 13:58       ` [virtio-comment] Re: [virtio-dev] " Paolo Bonzini
2020-11-05  6:35         ` Jie Deng
2020-11-10  7:31           ` Jie Deng
2020-11-10  7:51           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027071957-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jie.deng@intel.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox