From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Usyskin <alexander.usyskin@intel.com>,
linux-kernel@vger.kernel.org, Wang Yu <yu1.wang@intel.com>,
Liu Shuo <shuo.a.liu@intel.com>,
virtio-dev@lists.oasis-open.org
Subject: [virtio-dev] Re: [char-misc-next 13/13] mei: virtio: virtualization frontend driver
Date: Wed, 25 Nov 2020 16:08:23 -0500 [thread overview]
Message-ID: <20201125160326-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200818115147.2567012-14-tomas.winkler@intel.com>
On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote:
> +#ifndef VIRTIO_ID_MEI
> +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */
> +#endif
Just noticed now that this driver landed upstream. Can I ask that you
guys please register IDs with the virtio TC and not just pick a number
at random? In particular this is way outside allowed range.
IDs should also be listed in include/uapi/linux/virtio_ids.h
If people just pick random numbers like this collistions are unavoidable.
List of IDs is part of virtio spec, chapter "Device Types".
Please do this change now before this goes out to production!
Thanks!
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next parent reply other threads:[~2020-11-25 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200818115147.2567012-1-tomas.winkler@intel.com>
[not found] ` <20200818115147.2567012-14-tomas.winkler@intel.com>
2020-11-25 21:08 ` Michael S. Tsirkin [this message]
[not found] ` <7f6181d8e80d4efb9464e9ec436800b7@intel.com>
2020-11-26 9:58 ` [virtio-dev] Re: [char-misc-next 13/13] mei: virtio: virtualization frontend driver Michael S. Tsirkin
2020-12-03 21:51 ` Michael S. Tsirkin
[not found] ` <X8lgSb9vB6UoJbVB@kroah.com>
2020-12-05 19:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125160326-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.usyskin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuo.a.liu@intel.com \
--cc=tomas.winkler@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox