From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-7873-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 8605B986355 for ; Wed, 25 Nov 2020 21:08:31 +0000 (UTC) Date: Wed, 25 Nov 2020 16:08:23 -0500 From: "Michael S. Tsirkin" Message-ID: <20201125160326-mutt-send-email-mst@kernel.org> References: <20200818115147.2567012-1-tomas.winkler@intel.com> <20200818115147.2567012-14-tomas.winkler@intel.com> MIME-Version: 1.0 In-Reply-To: <20200818115147.2567012-14-tomas.winkler@intel.com> Subject: [virtio-dev] Re: [char-misc-next 13/13] mei: virtio: virtualization frontend driver Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Tomas Winkler Cc: Greg Kroah-Hartman , Alexander Usyskin , linux-kernel@vger.kernel.org, Wang Yu , Liu Shuo , virtio-dev@lists.oasis-open.org List-ID: On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote: > +#ifndef VIRTIO_ID_MEI > +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */ > +#endif Just noticed now that this driver landed upstream. Can I ask that you guys please register IDs with the virtio TC and not just pick a number at random? In particular this is way outside allowed range. IDs should also be listed in include/uapi/linux/virtio_ids.h If people just pick random numbers like this collistions are unavoidable. List of IDs is part of virtio spec, chapter "Device Types". Please do this change now before this goes out to production! Thanks! -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org