Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: virtio@lists.oasis-open.org
Subject: [virtio] [PATCH] typo: VIRTIO_NET_F_MAC_ADDR -> VIRTIO_NET_F_MAC
Date: Wed, 2 Dec 2020 04:35:25 -0500	[thread overview]
Message-ID: <20201202093517.114406-1-mst@redhat.com> (raw)

VIRTIO_NET_F_MAC_ADDR isn't defined. It's clear from context
that what is meant is VIRTIO_NET_F_MAC which controls whether
mac in config space is valid.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/90
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/content.tex b/content.tex
index 5b3121e..d5d779a 100644
--- a/content.tex
+++ b/content.tex
@@ -3948,7 +3948,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 
 The VIRTIO_NET_CTRL_MAC_ADDR_SET command is used to set the
 default MAC address which rx filtering
-accepts (and if VIRTIO_NET_F_MAC_ADDR has been negotiated,
+accepts (and if VIRTIO_NET_F_MAC has been negotiated,
 this will be reflected in \field{mac} in config space).
 
 The command-specific-data for VIRTIO_NET_CTRL_MAC_ADDR_SET is
@@ -3962,7 +3962,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 the VIRTIO_NET_CTRL_MAC_TABLE_SET command.
 
 The device MUST update \field{mac} in config space before it consumes
-the VIRTIO_NET_CTRL_MAC_ADDR_SET command, if VIRTIO_NET_F_MAC_ADDR has
+the VIRTIO_NET_CTRL_MAC_ADDR_SET command, if VIRTIO_NET_F_MAC has
 been negotiated.
 
 The device SHOULD drop incoming packets which have a destination MAC which
-- 
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


             reply	other threads:[~2020-12-02  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  9:35 Michael S. Tsirkin [this message]
2020-12-02 10:54 ` [virtio] Re: [virtio-comment] [PATCH] typo: VIRTIO_NET_F_MAC_ADDR -> VIRTIO_NET_F_MAC Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202093517.114406-1-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox