Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
* [virtio] [PATCH] typo: VIRTIO_NET_F_MAC_ADDR -> VIRTIO_NET_F_MAC
@ 2020-12-02  9:35 Michael S. Tsirkin
  2020-12-02 10:54 ` [virtio] Re: [virtio-comment] " Cornelia Huck
  0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2020-12-02  9:35 UTC (permalink / raw)
  To: virtio-comment, virtio-dev; +Cc: virtio

VIRTIO_NET_F_MAC_ADDR isn't defined. It's clear from context
that what is meant is VIRTIO_NET_F_MAC which controls whether
mac in config space is valid.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/90
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/content.tex b/content.tex
index 5b3121e..d5d779a 100644
--- a/content.tex
+++ b/content.tex
@@ -3948,7 +3948,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 
 The VIRTIO_NET_CTRL_MAC_ADDR_SET command is used to set the
 default MAC address which rx filtering
-accepts (and if VIRTIO_NET_F_MAC_ADDR has been negotiated,
+accepts (and if VIRTIO_NET_F_MAC has been negotiated,
 this will be reflected in \field{mac} in config space).
 
 The command-specific-data for VIRTIO_NET_CTRL_MAC_ADDR_SET is
@@ -3962,7 +3962,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 the VIRTIO_NET_CTRL_MAC_TABLE_SET command.
 
 The device MUST update \field{mac} in config space before it consumes
-the VIRTIO_NET_CTRL_MAC_ADDR_SET command, if VIRTIO_NET_F_MAC_ADDR has
+the VIRTIO_NET_CTRL_MAC_ADDR_SET command, if VIRTIO_NET_F_MAC has
 been negotiated.
 
 The device SHOULD drop incoming packets which have a destination MAC which
-- 
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-02 10:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-02  9:35 [virtio] [PATCH] typo: VIRTIO_NET_F_MAC_ADDR -> VIRTIO_NET_F_MAC Michael S. Tsirkin
2020-12-02 10:54 ` [virtio] Re: [virtio-comment] " Cornelia Huck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox