From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Srivatsa Vaddagiri <svaddagi@qti.qualcomm.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
Trilok Soni <tsoni@quicinc.com>,
Pratik Patel <pratikp@quicinc.com>
Subject: Re: [PATCH v1] virtio-mmio: Specify wait needed in driver during reset
Date: Mon, 26 Jul 2021 09:19:26 -0400 [thread overview]
Message-ID: <20210726091851-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87eebl5msn.fsf@redhat.com>
On Mon, Jul 26, 2021 at 01:36:56PM +0200, Cornelia Huck wrote:
> On Mon, Jul 26 2021, Srivatsa Vaddagiri <svaddagi@qti.qualcomm.com> wrote:
>
> >> > +indicated by a read of \field{Status} returning 0. Such a device MUST also
> >> > fail to accept
> >> > +FEATURES_OK bit if driver does not negotiate VIRTIO_F_MMIO_RESET_WAIT.
> >>
> >> So, this basically means that an older driver that does not know the new
> >> feature bit will not work with devices offering this bit, even if it did
> >> poll? This seems acceptable, I just wanted to spell it out.
> >
> > Yes I believe that's the desired result. Device has no way to know if driver
> > will poll for reset completion or not unless it accepts the feature.
> > Are you suggesting we explicitly put in some text in spec to that
> > effect?
>
> Not sure whether it is needed (do others have an opinion?), but probably
> not.
What about resets before FEATURES_OK? How are these handled?
--
MST
next prev parent reply other threads:[~2021-07-26 13:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 14:55 [PATCH v1] virtio-mmio: Specify wait needed in driver during reset Srivatsa Vaddagiri
2021-07-26 11:03 ` [virtio-dev] " Cornelia Huck
2021-07-26 11:25 ` Srivatsa Vaddagiri
2021-07-26 11:36 ` [virtio-dev] " Cornelia Huck
2021-07-26 13:19 ` Michael S. Tsirkin [this message]
2021-07-26 14:09 ` Cornelia Huck
2021-07-26 14:17 ` Srivatsa Vaddagiri
2021-07-26 19:03 ` Michael S. Tsirkin
2021-07-27 9:52 ` [virtio-dev] " Srivatsa Vaddagiri
2021-07-29 15:21 ` Cornelia Huck
2021-07-30 3:49 ` Srivatsa Vaddagiri
2021-08-02 6:06 ` Jason Wang
2021-08-11 10:05 ` [virtio-dev] " Srivatsa Vaddagiri
2021-08-16 2:09 ` Jason Wang
2021-08-16 5:35 ` Michael S. Tsirkin
[not found] ` <20210816063550.GD5604@quicinc.com>
2021-08-16 11:48 ` Michael S. Tsirkin
2021-08-16 13:34 ` Srivatsa Vaddagiri
2021-08-16 14:37 ` Michael S. Tsirkin
2021-08-16 14:58 ` Srivatsa Vaddagiri
2021-08-17 5:45 ` Jason Wang
2021-08-17 7:51 ` Michael S. Tsirkin
2021-08-17 8:15 ` Jason Wang
2021-08-17 10:03 ` Srivatsa Vaddagiri
2021-08-17 12:48 ` Srivatsa Vaddagiri
2021-08-18 2:57 ` Jason Wang
2021-08-18 2:54 ` Jason Wang
2021-08-18 5:15 ` Srivatsa Vaddagiri
2021-08-18 5:40 ` Jason Wang
2021-08-18 5:51 ` Srivatsa Vaddagiri
2021-08-18 6:04 ` Jason Wang
2021-08-18 6:13 ` Srivatsa Vaddagiri
2021-08-24 16:57 ` Srivatsa Vaddagiri
2021-08-20 3:56 ` Jason Wang
2021-08-20 11:15 ` Michael S. Tsirkin
2021-07-26 13:18 ` Michael S. Tsirkin
2021-07-26 14:13 ` [virtio-dev] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726091851-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=pratikp@quicinc.com \
--cc=svaddagi@qti.qualcomm.com \
--cc=tsoni@quicinc.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox