Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com,
	Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com,
	etienne.carriere@linaro.org, vincent.guittot@linaro.org,
	souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com,
	peter.hilber@opensynergy.com, alex.bennee@linaro.org,
	jean-philippe@linaro.org, mikhail.golubev@opensynergy.com,
	anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com,
	Andriy.Tryshnivskyy@opensynergy.com
Subject: [virtio-dev] Re: [PATCH v6 08/17] firmware: arm_scmi: Add priv parameter to scmi_rx_callback
Date: Wed, 28 Jul 2021 18:25:46 +0100	[thread overview]
Message-ID: <20210728172546.GL6592@e120937-lin> (raw)
In-Reply-To: <20210728142625.zbx7zbeffwsksjl5@bogus>

On Wed, Jul 28, 2021 at 03:26:25PM +0100, Sudeep Holla wrote:
> On Mon, Jul 12, 2021 at 03:18:24PM +0100, Cristian Marussi wrote:
> > Add a new opaque void *priv parameter to scmi_rx_callback which can be
> > optionally provided by the transport layer when invoking scmi_rx_callback
> > and that will be passed back to the transport layer in xfer->priv.
> > 
> > This can be used by transports that needs to keep track of their specific
> > data structures together with the valid xfers.
> >

Hi,

> 
> This change looks simple but doesn't make sense on its own. I assume you don't
> want to add all these in the patch making use of priv which makes sense. Not
> sure if the next patch uses it, but I prefer to keep them as close as possible
> if it is not too much of a hassle.
> 

Right, yes I'll move it close to 17/17 which is the actual user of this
at the end.

Thanks,
Cristian


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2021-07-28 17:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210712141833.6628-1-cristian.marussi@arm.com>
2021-07-15 16:35 ` [virtio-dev] Re: [PATCH v6 00/17] Introduce SCMI transport based on VirtIO Peter Hilber
     [not found]   ` <20210719113657.GI49078@e120937-lin>
2021-07-22  8:30     ` Peter Hilber
     [not found] ` <20210712141833.6628-8-cristian.marussi@arm.com>
2021-07-15 16:36   ` [virtio-dev] Re: [PATCH v6 07/17] firmware: arm_scmi: Handle concurrent and out-of-order messages Peter Hilber
     [not found]     ` <20210719091451.GF49078@e120937-lin>
2021-07-22  8:32       ` Peter Hilber
     [not found]   ` <20210802101032.ozlidylogmdt2zqu@bogus>
2021-08-02 10:27     ` Cristian Marussi
     [not found] ` <20210712141833.6628-11-cristian.marussi@arm.com>
2021-07-15 16:36   ` [virtio-dev] Re: [PATCH v6 10/17] firmware: arm_scmi: Make polling mode optional Peter Hilber
     [not found]   ` <20210728143418.5lton6l7t2oa6rtz@bogus>
2021-07-28 17:41     ` Cristian Marussi
     [not found] ` <20210712141833.6628-15-cristian.marussi@arm.com>
2021-07-15 16:36   ` [virtio-dev] Re: [PATCH v6 14/17] firmware: arm_scmi: Add message passing abstractions for transports Peter Hilber
     [not found] ` <20210712141833.6628-7-cristian.marussi@arm.com>
     [not found]   ` <20210728141746.chqwhspnwviz67xn@bogus>
2021-07-28 16:54     ` [virtio-dev] Re: [PATCH v6 06/17] firmware: arm_scmi: Introduce monotonically increasing tokens Cristian Marussi
     [not found]       ` <20210802102425.67bhbvyrgzio7zzg@bogus>
2021-08-03 12:52         ` Cristian Marussi
     [not found] ` <20210712141833.6628-9-cristian.marussi@arm.com>
     [not found]   ` <20210728142625.zbx7zbeffwsksjl5@bogus>
2021-07-28 17:25     ` Cristian Marussi [this message]
     [not found] ` <20210712141833.6628-12-cristian.marussi@arm.com>
     [not found]   ` <20210728145033.wpobgpxane2t2brc@bogus>
2021-07-29 16:18     ` [virtio-dev] Re: [PATCH v6 11/17] firmware: arm_scmi: Make SCMI transports configurable Cristian Marussi
     [not found] ` <20210712141833.6628-16-cristian.marussi@arm.com>
     [not found]   ` <20210728153647.llr6bfhyja5ezkth@bogus>
2021-07-29 16:19     ` [virtio-dev] Re: [PATCH v6 15/17] firmware: arm_scmi: Add optional link_supplier() transport op Cristian Marussi
     [not found] ` <YROY6YntswWxfaub@google.com>
2021-08-11 15:26   ` [virtio-dev] Re: [PATCH v6 00/17] Introduce SCMI transport based on VirtIO Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728172546.GL6592@e120937-lin \
    --to=cristian.marussi@arm.com \
    --cc=Andriy.Tryshnivskyy@opensynergy.com \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=Vasyl.Vavrychuk@opensynergy.com \
    --cc=alex.bennee@linaro.org \
    --cc=anton.yakovlev@opensynergy.com \
    --cc=etienne.carriere@linaro.org \
    --cc=f.fainelli@gmail.com \
    --cc=igor.skalkin@opensynergy.com \
    --cc=james.quinlan@broadcom.com \
    --cc=jean-philippe@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikhail.golubev@opensynergy.com \
    --cc=peter.hilber@opensynergy.com \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox