From: "Michael S. Tsirkin" <mst@redhat.com>
To: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
Cc: Jason Wang <jasowang@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Virtio-Dev <virtio-dev@lists.oasis-open.org>,
Trilok Soni <tsoni@quicinc.com>,
Pratik Patel <pratikp@quicinc.com>
Subject: Re: [PATCH v2] virtio-mmio: Specify wait needed in driver during reset
Date: Mon, 16 Aug 2021 01:07:19 -0400 [thread overview]
Message-ID: <20210816010636-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210816045718.GB5604@quicinc.com>
On Mon, Aug 16, 2021 at 10:27:18AM +0530, Srivatsa Vaddagiri wrote:
> * Jason Wang <jasowang@redhat.com> [2021-08-16 10:10:56]:
>
> > > +After writing 0 to \field{Status}, which triggers a reset of device, the driver MUST wait for a read of
> > > +\field{Status} to return 0 before proceeding with the remaining steps of initializing the device.
> > > +
> >
> > Do we need to limit this behaviour to 0x3 only?
>
> I felt it will be simple for drivers to unconditionally poll for reset
> completion (which is the right thing to do IMO), but can make it conditional to
> version 3 only if you say so.
>
> - vatsa
We can't make spec changes that declare all existing drivers
non-conformant.
> ---
>
> Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a
> non-member to the virtio-dev mailing list for consideration and inclusion.
>
next prev parent reply other threads:[~2021-08-16 5:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 14:53 [PATCH v2] virtio-mmio: Specify wait needed in driver during reset Srivatsa Vaddagiri
2021-08-16 2:10 ` Jason Wang
2021-08-16 4:57 ` Srivatsa Vaddagiri
2021-08-16 5:07 ` Michael S. Tsirkin [this message]
2021-08-16 5:30 ` Michael S. Tsirkin
2021-08-16 6:22 ` Srivatsa Vaddagiri
2021-08-20 4:01 ` Jason Wang
2021-08-17 15:26 ` [virtio-dev] " Cornelia Huck
2021-08-18 2:39 ` Jason Wang
2021-08-18 6:34 ` [virtio-dev] " Cornelia Huck
2021-08-20 3:48 ` Jason Wang
2021-08-20 11:18 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816010636-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=pratikp@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=tsoni@quicinc.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox