From: "Michael S. Tsirkin" <mst@redhat.com>
To: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
Cc: Jason Wang <jasowang@redhat.com>,
Srivatsa Vaddagiri <svaddagi@qti.qualcomm.com>,
Cornelia Huck <cohuck@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
Trilok Soni <quic_tsoni@quicinc.com>,
Pratik Patel <quic_pratikp@quicinc.com>
Subject: Re: [virtio-dev] Re: [PATCH v1] virtio-mmio: Specify wait needed in driver during reset
Date: Mon, 16 Aug 2021 07:48:56 -0400 [thread overview]
Message-ID: <20210816074558-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210816063550.GD5604@quicinc.com>
On Mon, Aug 16, 2021 at 12:05:50PM +0530, Srivatsa Vaddagiri wrote:
> * Michael S. Tsirkin <mst@redhat.com> [2021-08-16 01:35:46]:
>
> > So thinking about all this, quite early in the setup process we
> > have:
> >
> > /* Figure out what features the device supports. */
> > device_features = dev->config->get_features(dev);
> >
> >
> > isn't this sufficient? this will flush out
> > all writes and device can defer responding to reads
> > until reset is complete.
>
> Hmm not sure if that's possible in all MMIO devices? I think a while back Jason
> felt some of the MMIO devices, their registers could act as plain DRAM for
> reads, which means device can't block such reads?
>
> - vatsa
Is it worth bothering about theoretical issues though? Jason what is
your take?
> ---
>
> Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a
> non-member to the virtio-dev mailing list for consideration and inclusion.
next prev parent reply other threads:[~2021-08-16 11:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 14:55 [PATCH v1] virtio-mmio: Specify wait needed in driver during reset Srivatsa Vaddagiri
2021-07-26 11:03 ` [virtio-dev] " Cornelia Huck
2021-07-26 11:25 ` Srivatsa Vaddagiri
2021-07-26 11:36 ` [virtio-dev] " Cornelia Huck
2021-07-26 13:19 ` Michael S. Tsirkin
2021-07-26 14:09 ` [virtio-dev] " Cornelia Huck
2021-07-26 14:17 ` Srivatsa Vaddagiri
2021-07-26 19:03 ` Michael S. Tsirkin
2021-07-27 9:52 ` [virtio-dev] " Srivatsa Vaddagiri
2021-07-29 15:21 ` Cornelia Huck
2021-07-30 3:49 ` Srivatsa Vaddagiri
2021-08-02 6:06 ` Jason Wang
2021-08-11 10:05 ` [virtio-dev] " Srivatsa Vaddagiri
2021-08-16 2:09 ` Jason Wang
2021-08-16 5:35 ` Michael S. Tsirkin
[not found] ` <20210816063550.GD5604@quicinc.com>
2021-08-16 11:48 ` Michael S. Tsirkin [this message]
2021-08-16 13:34 ` Srivatsa Vaddagiri
2021-08-16 14:37 ` Michael S. Tsirkin
2021-08-16 14:58 ` Srivatsa Vaddagiri
2021-08-17 5:45 ` Jason Wang
2021-08-17 7:51 ` Michael S. Tsirkin
2021-08-17 8:15 ` Jason Wang
2021-08-17 10:03 ` Srivatsa Vaddagiri
2021-08-17 12:48 ` Srivatsa Vaddagiri
2021-08-18 2:57 ` Jason Wang
2021-08-18 2:54 ` Jason Wang
2021-08-18 5:15 ` Srivatsa Vaddagiri
2021-08-18 5:40 ` Jason Wang
2021-08-18 5:51 ` Srivatsa Vaddagiri
2021-08-18 6:04 ` Jason Wang
2021-08-18 6:13 ` Srivatsa Vaddagiri
2021-08-24 16:57 ` Srivatsa Vaddagiri
2021-08-20 3:56 ` Jason Wang
2021-08-20 11:15 ` Michael S. Tsirkin
2021-07-26 13:18 ` Michael S. Tsirkin
2021-07-26 14:13 ` [virtio-dev] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816074558-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=quic_pratikp@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=svaddagi@qti.qualcomm.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox