From: "Michael S. Tsirkin" <mst@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Cornelia Huck" <cohuck@redhat.com>,
"Jie Deng" <jie.deng@intel.com>, "Wolfram Sang" <wsa@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Bill Mills" <bill.mills@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
virtio-dev@lists.oasis-open.org, stratos-dev@op-lists.linaro.org,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH V2] virtio: i2c: Allow zero-length transactions
Date: Tue, 17 Aug 2021 02:47:00 -0400 [thread overview]
Message-ID: <20210817024607-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210817035324.r27cdx3yu2j4qmms@vireshk-i7>
On Tue, Aug 17, 2021 at 09:23:24AM +0530, Viresh Kumar wrote:
> On 16-08-21, 10:45, Michael S. Tsirkin wrote:
> > On Mon, Aug 16, 2021 at 03:17:23PM +0530, Viresh Kumar wrote:
> > > The I2C protocol allows zero-length requests with no data, like the
> > > SMBus Quick command, where the command is inferred based on the
> > > read/write flag itself.
> >
> > So I wonder. What if we allow zero-length buffers in virtio? Would that
> > address the need?
>
> There are three things this patch does, all of which are important
> IMO:
>
> 1. Drop the need of passing both write and read buffers, as that isn't
> required really since we already have another way of linking
> different transfers using the fail-next flag.
>
> 2. Make the buffer optional, for zero-length transfers.
>
> 3. Pass the r/w flag separately, which is kind of relevant because of
> 2 (zero-length transfers) only.
>
>
> I think (1) can be done separately anyway, and we may be able to solve
> (2) and (3) if we allow zero-length buffers in virtio itself.
OK, so yea. Let's split this up please.
> --
> viresh
next prev parent reply other threads:[~2021-08-17 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 9:47 [PATCH V2] virtio: i2c: Allow zero-length transactions Viresh Kumar
2021-08-16 14:45 ` Michael S. Tsirkin
2021-08-17 3:53 ` Viresh Kumar
2021-08-17 6:47 ` Michael S. Tsirkin [this message]
2021-08-17 10:43 ` Viresh Kumar
2021-08-18 2:38 ` [virtio-dev] " Jie Deng
2021-08-18 3:26 ` Viresh Kumar
2021-08-18 8:03 ` Arnd Bergmann
2021-08-18 8:09 ` Viresh Kumar
2021-08-23 7:31 ` Viresh Kumar
2021-09-01 0:03 ` Michael S. Tsirkin
2021-09-01 6:22 ` Viresh Kumar
2021-09-01 7:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817024607-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bill.mills@linaro.org \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=jie.deng@intel.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox