From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Srivatsa Vaddagiri <svaddagi@qti.qualcomm.com>,
Cornelia Huck <cohuck@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
Trilok Soni <quic_tsoni@quicinc.com>,
Pratik Patel <quic_pratikp@quicinc.com>
Subject: Re: [virtio-dev] Re: [PATCH v1] virtio-mmio: Specify wait needed in driver during reset
Date: Wed, 18 Aug 2021 11:43:05 +0530 [thread overview]
Message-ID: <20210818061305.GE9207@quicinc.com> (raw)
In-Reply-To: <CACGkMEtu+FRv_kPKqnzFhQybrt9fVy8QROLuv8Z5i3KyL8GWOg@mail.gmail.com>
* Jason Wang <jasowang@redhat.com> [2021-08-18 14:04:04]:
> > Fine let me take a stab at the next version which will have this:
> >
> > * Introduce a status bit for device to indicate "reset in progress". This could
> > be adopted by other transports also (for ex PCI).
>
> I may miss something discussion but any reason that the current
> VIRTIO_MMIO_STATUS is not sufficient?
I think Mike suggested we specify what device would return while reset is in
progress, rather than any arbitrary non-zero value:
https://lists.oasis-open.org/archives/virtio-dev/202108/msg00070.html
> > * For v3 MMIO devices, driver, after initiating reset, should wait until
> > status = 0 or device indicates "failure". What the driver does when it sees
> > failure can be implementation defined (it can give up or try reset few more
> > times)
>
> Yes, but let's wait a little bit to see if it is agreed by others.
Sure.
Mike,
Do you suggest we add this as well for v3 device?
"after writing 0 to Status and before reading any fields, the driver
MUST read Status and wait for a read to return 0 or indicate failure"
- vatsa
--
Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a
non-member to the virtio-dev mailing list for consideration and inclusion.
next prev parent reply other threads:[~2021-08-18 6:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 14:55 [PATCH v1] virtio-mmio: Specify wait needed in driver during reset Srivatsa Vaddagiri
2021-07-26 11:03 ` [virtio-dev] " Cornelia Huck
2021-07-26 11:25 ` Srivatsa Vaddagiri
2021-07-26 11:36 ` [virtio-dev] " Cornelia Huck
2021-07-26 13:19 ` Michael S. Tsirkin
2021-07-26 14:09 ` [virtio-dev] " Cornelia Huck
2021-07-26 14:17 ` Srivatsa Vaddagiri
2021-07-26 19:03 ` Michael S. Tsirkin
2021-07-27 9:52 ` [virtio-dev] " Srivatsa Vaddagiri
2021-07-29 15:21 ` Cornelia Huck
2021-07-30 3:49 ` Srivatsa Vaddagiri
2021-08-02 6:06 ` Jason Wang
2021-08-11 10:05 ` [virtio-dev] " Srivatsa Vaddagiri
2021-08-16 2:09 ` Jason Wang
2021-08-16 5:35 ` Michael S. Tsirkin
[not found] ` <20210816063550.GD5604@quicinc.com>
2021-08-16 11:48 ` Michael S. Tsirkin
2021-08-16 13:34 ` Srivatsa Vaddagiri
2021-08-16 14:37 ` Michael S. Tsirkin
2021-08-16 14:58 ` Srivatsa Vaddagiri
2021-08-17 5:45 ` Jason Wang
2021-08-17 7:51 ` Michael S. Tsirkin
2021-08-17 8:15 ` Jason Wang
2021-08-17 10:03 ` Srivatsa Vaddagiri
2021-08-17 12:48 ` Srivatsa Vaddagiri
2021-08-18 2:57 ` Jason Wang
2021-08-18 2:54 ` Jason Wang
2021-08-18 5:15 ` Srivatsa Vaddagiri
2021-08-18 5:40 ` Jason Wang
2021-08-18 5:51 ` Srivatsa Vaddagiri
2021-08-18 6:04 ` Jason Wang
2021-08-18 6:13 ` Srivatsa Vaddagiri [this message]
2021-08-24 16:57 ` Srivatsa Vaddagiri
2021-08-20 3:56 ` Jason Wang
2021-08-20 11:15 ` Michael S. Tsirkin
2021-07-26 13:18 ` Michael S. Tsirkin
2021-07-26 14:13 ` [virtio-dev] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818061305.GE9207@quicinc.com \
--to=quic_svaddagi@quicinc.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=quic_pratikp@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=svaddagi@qti.qualcomm.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox