From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
To: virtio-dev@lists.oasis-open.org
Cc: mst@redhat.com, jasowang@redhat.com
Subject: [virtio-dev] Timing out virtio-pci config space access
Date: Thu, 4 Nov 2021 22:37:40 +0530 [thread overview]
Message-ID: <20211104170740.GA14929@quicinc.com> (raw)
We are working on a virtio-pci implementation on a Type-1 hypervisor where
backend drivers are hosted in another VM and are considered untrusted. PCI is
the virtio transport used in this case.
One issue that crops up is a read/write of config space can potentially block
forever, as the backend is untrusted and could be causing a denial-of-service of
sorts. This causes the vcpu to stall forever. I was wondering if we can timeout
in such case and have the hypervisor break the stall by letting read return
"error" (-1) along with setting DEVICE_NEEDS_RESET in status register. Will that
allow Linux guest driver to gracefully fail its probe? I don't see where Linux
handles DEVICE_NEEDS_RESET currently and also am not sure if returning -1 will
lead to graceful failure of the driver alone (we don't want VM to come down or
panic because of a mis-behaving device).
I saw some discussions in this regard for vDPA where similar solution seem to
have been discussed.
https://lkml.org/lkml/2021/7/6/219
Would that work for PCI transport also?
Thanks
vatsa
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next reply other threads:[~2021-11-04 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 17:07 Srivatsa Vaddagiri [this message]
2021-11-05 4:52 ` [virtio-dev] Re: Timing out virtio-pci config space access Jason Wang
2021-11-05 12:42 ` Srivatsa Vaddagiri
2021-11-05 7:38 ` [virtio-dev] " Michael S. Tsirkin
2021-11-05 12:29 ` Srivatsa Vaddagiri
2021-11-05 13:13 ` Michael S. Tsirkin
2021-11-05 14:12 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104170740.GA14929@quicinc.com \
--to=quic_svaddagi@quicinc.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox