Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: Viresh Kumar <viresh.kumar@linaro.org>, virtio@lists.oasis-open.org
Subject: [virtio-dev] [PATCH] virtio-gpio: offered -> negotiated
Date: Tue, 25 Jan 2022 07:24:39 -0500	[thread overview]
Message-ID: <20220125122332.64473-1-mst@redhat.com> (raw)

virtqueues are only discovered after FEATURES_OK.
As such it makes no sense to talk about virtqueues being affected by
features which are offered but not negotiated, and doing so will confuse
the reader.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Viresh, others your thoughts on this? Looks like an obvious typo
to me, and something that I think we can fix under the editorial
changes rule.

 virtio-gpio.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtio-gpio.tex b/virtio-gpio.tex
index 55c553f..8e5c7f0 100644
--- a/virtio-gpio.tex
+++ b/virtio-gpio.tex
@@ -15,7 +15,7 @@ \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues}
 \end{description}
 
 The \field{eventq} virtqueue is available only if the \field{VIRTIO_GPIO_F_IRQ}
-feature is offered by the device.
+feature has been negotiated.
 
 \subsection{Feature bits}\label{sec:Device Types / GPIO Device / Feature bits}
 
-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


             reply	other threads:[~2022-01-25 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 12:24 Michael S. Tsirkin [this message]
2022-02-09  6:16 ` [virtio-dev] Re: [PATCH] virtio-gpio: offered -> negotiated Viresh Kumar
2022-04-13  9:35 ` [virtio] Re: [virtio-dev] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125122332.64473-1-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=viresh.kumar@linaro.org \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox