From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, virtio@lists.oasis-open.org
Subject: Re: [virtio-dev] [PATCH] fixupdiff: escape ^ caret
Date: Wed, 20 Apr 2022 11:33:17 -0400 [thread overview]
Message-ID: <20220420100135-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87wnfj7w0v.fsf@redhat.com>
On Wed, Apr 20, 2022 at 02:57:04PM +0200, Cornelia Huck wrote:
> On Tue, Apr 19 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > Since commit:
> >
> > commit 1e30753d53d222fbe955f0643583d756105d557e
> > Author: Jan Kiszka <jan.kiszka@siemens.com>
> > Date: Fri Oct 11 13:43:41 2019 +0200
> >
> > Fix ^= in example code
> >
> > Trying to escaping ^ here only leaves the backslash in the output.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > we have plain ^ inside listing. Escape it with \ but only
> > if not already escaped (as output of diff with old source will be).
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > fixupdiff.pl | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Thanks, pushed as an editorial update.
Sounds good! OK let me compile this all, upload and we can
get the ball rolling with the 1st vote.
--
MST
prev parent reply other threads:[~2022-04-20 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 16:30 [virtio-dev] [PATCH] fixupdiff: escape ^ caret Michael S. Tsirkin
2022-04-20 12:57 ` [virtio-comment] " Cornelia Huck
2022-04-20 15:33 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420100135-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox