From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Parav Pandit <parav@nvidia.com>,
Virtio-Dev <virtio-dev@lists.oasis-open.org>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Cornelia Huck <cohuck@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state
Date: Thu, 28 Apr 2022 02:30:22 -0400 [thread overview]
Message-ID: <20220428022714-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEsWMxXEyNKue7f8cu4m5CkUmZNexbjzK6ha5eDFCmhR1w@mail.gmail.com>
On Thu, Apr 28, 2022 at 02:13:42PM +0800, Jason Wang wrote:
> > queue_reset removal has far more editorial changes.
> > Before I update the v4 to incorporate, please discuss/sync with Michael or others what is best course of action from spec timing perspective.
> > I am ok either way to draft either by
> > (a) removal of queue_reset register and allow queue_disable by replacing RING_RESET definition in v4
> > Or
> > (b) fixing the polarity as done in v3
>
> Ok.
>
> Thanks
So Jason, what is your take? I am inclined to keep queue reset register
and just flip the polarity. Less spec work and semantics are more or
less clear. Not helpful for migration - limited to queue
resize, watchdog and similar uses - but if we are expanding
scope to migration that makes it imo not 1.2 material.
--
MST
next prev parent reply other threads:[~2022-04-28 6:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 10:25 [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state Parav Pandit
2022-04-27 11:29 ` [virtio-dev] " Jason Wang
2022-04-27 11:44 ` Xuan Zhuo
2022-04-28 3:46 ` Jason Wang
2022-04-27 14:51 ` Parav Pandit
2022-04-27 15:29 ` Michael S. Tsirkin
2022-04-27 15:39 ` Parav Pandit
2022-04-27 15:43 ` Michael S. Tsirkin
2022-04-27 15:57 ` Parav Pandit
2022-04-27 16:15 ` Parav Pandit
2022-04-27 19:32 ` Michael S. Tsirkin
2022-04-28 1:52 ` Parav Pandit
2022-04-28 3:40 ` Jason Wang
2022-04-28 4:00 ` Parav Pandit
2022-04-28 6:13 ` Jason Wang
2022-04-28 6:30 ` Michael S. Tsirkin [this message]
2022-04-28 6:56 ` Jason Wang
2022-04-27 19:28 ` Michael S. Tsirkin
2022-04-27 19:29 ` Parav Pandit
2022-04-28 3:15 ` Jason Wang
2022-04-28 3:24 ` Parav Pandit
2022-04-28 3:43 ` Jason Wang
2022-04-28 4:56 ` Michael S. Tsirkin
2022-04-28 6:10 ` Jason Wang
2022-04-28 6:26 ` Michael S. Tsirkin
2022-04-28 8:20 ` Jason Wang
2022-04-27 12:48 ` [virtio-dev] " Cornelia Huck
2022-04-28 1:09 ` [virtio-dev] " Parav Pandit
2022-04-27 20:39 ` [virtio-dev] " Michael S. Tsirkin
2022-04-28 1:49 ` Parav Pandit
2022-04-28 7:33 ` [virtio-comment] " Cornelia Huck
2022-04-28 19:13 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428022714-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox