Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Patrick Mosca <pmosca@apple.com>
Cc: Virtio-Dev <virtio-dev@lists.oasis-open.org>,
	Cameron Esfahani <dirty@apple.com>
Subject: Re: [virtio-dev] Clarification of VIRTIO_F_EVENT_IDX driver conditions.
Date: Sun, 5 Jun 2022 16:29:08 -0400	[thread overview]
Message-ID: <20220605162839-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <6355541D-E117-4E7F-B5D9-3CD0028ED7FF@apple.com>

On Wed, Jun 01, 2022 at 01:03:27PM -0700, Patrick Mosca wrote:
> We ran into an edge case in the VIRTIO_F_EVENT_IDX feature where a notification could be missed if there is a "streak" in skipped notifications. If the difference between the event index and available index wraps before a notification is needed, there exists a case where a notification must be sent but is not sent.
> 
> 
> Signed-off-by: Patrick Mosca <pmosca@apple.com>
> Signed-off-by: Cameron Esfahani <dirty@apple.com>
> ---
>  split-ring.tex | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/split-ring.tex b/split-ring.tex
> index bfef62d..9650e5e 100644
> --- a/split-ring.tex
> +++ b/split-ring.tex
> @@ -530,6 +530,9 @@ \subsection{Available Buffer Notification Suppression}\label{sec:Basic Facilitie
>          \item If the \field{idx} field in the available ring (which determined
>            where that descriptor index was placed) was equal to
>            \field{avail_event}, the driver MUST send a notification.
> +        \item If the number of descriptors added to the queue since
> +          the last notification is greater than 65535, the driver MUST
> +          send a notification.
>          \item Otherwise the driver SHOULD NOT send a notification.
>    \end{itemize}
>  \end{itemize}
> -- 
> 2.32.0 (Apple Git-131)
> 
> 
> -Patrick Mosca

I am not sure I understand. Can you give an example of how the issue
triggers please?

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2022-06-05 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 20:03 [virtio-dev] Clarification of VIRTIO_F_EVENT_IDX driver conditions Patrick Mosca
2022-06-05 20:29 ` Michael S. Tsirkin [this message]
2022-06-16 20:53   ` Patrick Mosca
2022-06-17 10:30     ` Michael S. Tsirkin
2022-06-24 22:39       ` Patrick Mosca
2022-08-11 16:58         ` Patrick Mosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220605162839-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=dirty@apple.com \
    --cc=pmosca@apple.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox