From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
mst@redhat.com, cohuck@redhat.com, sgarzare@redhat.com,
stefanha@redhat.com, nrupal.jani@intel.com,
Piotr.Uminski@intel.com, hang.yuan@intel.com
Cc: virtio@lists.oasis-open.org,
Zhu Lingshan <lingshan.zhu@intel.com>,
oren@nvidia.com, parav@nvidia.com, shahafs@nvidia.com,
aadam@redhat.com, eperezma@redhat.com,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [PATCH RFC v7 4/8] Add admin_queue_index register to PCI common configuration structure
Date: Fri, 12 Aug 2022 13:19:11 -0400 [thread overview]
Message-ID: <20220812171841.12183-5-mst@redhat.com> (raw)
In-Reply-To: <20220812171841.12183-1-mst@redhat.com>
From: Max Gurtovoy <mgurtovoy@nvidia.com>
This new register will be used for querying the index of the admin
virtqueue of a virtio device. To configure, reset or enable the admin
virtqueue, the driver should follow existing queue configuration/setup
sequence.
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
content.tex | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/content.tex b/content.tex
index 6ce1c07..297cb4a 100644
--- a/content.tex
+++ b/content.tex
@@ -904,6 +904,9 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
le64 queue_device; /* read-write */
le16 queue_notify_data; /* read-only for driver */
le16 queue_reset; /* read-write */
+
+ /* About the administration virtqueue. */
+ le16 admin_queue_index; /* read-only for driver */
};
\end{lstlisting}
@@ -989,6 +992,10 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
This field exists only if VIRTIO_F_RING_RESET has been
negotiated. (see \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}).
+\item[\field{admin_queue_index}]
+ The device uses this to report the index of the administration virtqueue.
+ This field is valid only if VIRTIO_F_ADMIN_VQ has been negotiated.
+
\end{description}
\devicenormative{\paragraph}{Common configuration structure layout}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Common configuration structure layout}
@@ -1075,6 +1082,9 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
were used before the queue reset.
(see \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}).
+If VIRTIO_F_ADMIN_VQ has been negotiated, the driver MUST
+configure the administration virtqueue using the value of \field{admin_queue_index}.
+
\subsubsection{Notification structure layout}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Notification capability}
The notification location is found using the VIRTIO_PCI_CAP_NOTIFY_CFG
@@ -6947,6 +6957,10 @@ \chapter{Reserved Feature Bits}\label{sec:Reserved Feature Bits}
See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}.
\item[VIRTIO_F_ADMIN_VQ (41)] This feature indicates that an administration virtqueue is supported.
+ At the moment this feature is only supported for devices using
+ \ref{sec:Virtio Transport Options / Virtio Over PCI
+ Bus}~\nameref{sec:Virtio Transport Options / Virtio Over PCI Bus}
+ as the transport.
\end{description}
--
MST
next prev parent reply other threads:[~2022-08-12 17:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 17:18 [PATCH RFC v7 0/8] Introduce device group and device management Michael S. Tsirkin
2022-08-12 17:18 ` [PATCH RFC v7 1/8] Introduce device group Michael S. Tsirkin
2022-08-16 16:51 ` [virtio-comment] " Max Gurtovoy
2022-08-18 8:37 ` Jason Wang
2022-08-18 8:56 ` Michael S. Tsirkin
2022-08-12 17:19 ` [PATCH RFC v7 2/8] Introduce group administration commands Michael S. Tsirkin
2022-08-16 22:26 ` Max Gurtovoy
2022-08-18 8:46 ` [virtio-comment] " Jason Wang
2022-08-18 8:51 ` [virtio] " Michael S. Tsirkin
2022-08-19 0:26 ` Jason Wang
2022-08-19 3:28 ` Michael S. Tsirkin
2022-08-19 4:37 ` [virtio-comment] " Jason Wang
2022-08-19 23:41 ` Max Gurtovoy
2022-08-23 3:32 ` [virtio-comment] " Jason Wang
2022-08-24 9:20 ` Max Gurtovoy
2022-08-12 17:19 ` [PATCH RFC v7 3/8] Introduce virtio admin virtqueue Michael S. Tsirkin
2022-08-16 22:29 ` [virtio-comment] " Max Gurtovoy
2022-08-12 17:19 ` Michael S. Tsirkin [this message]
2022-08-16 22:31 ` [PATCH RFC v7 4/8] Add admin_queue_index register to PCI common configuration structure Max Gurtovoy
2022-08-18 8:49 ` Jason Wang
2022-08-18 8:52 ` Michael S. Tsirkin
2022-08-18 8:55 ` Max Gurtovoy
2022-08-19 0:28 ` Jason Wang
2022-08-19 3:50 ` Michael S. Tsirkin
2022-08-12 17:19 ` [PATCH RFC v7 5/8] MMIO: disallow using admin vq bit Michael S. Tsirkin
2022-08-12 17:19 ` [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ Michael S. Tsirkin
2022-08-16 14:48 ` [virtio] " Halil Pasic
2022-08-16 15:48 ` Michael S. Tsirkin
2022-08-16 15:50 ` Michael S. Tsirkin
2022-08-16 22:36 ` [virtio-comment] " Max Gurtovoy
2022-08-18 13:39 ` Halil Pasic
2022-08-19 3:57 ` Michael S. Tsirkin
2022-08-23 23:45 ` [virtio-dev] " Halil Pasic
2022-08-28 9:35 ` Michael S. Tsirkin
2022-08-31 14:33 ` [virtio] " Halil Pasic
2022-08-31 14:50 ` Michael S. Tsirkin
2022-09-01 23:33 ` Halil Pasic
2022-08-29 18:28 ` Michael S. Tsirkin
2022-08-30 12:48 ` Halil Pasic
2022-08-30 14:31 ` Cornelia Huck
2022-08-12 17:19 ` [PATCH RFC v7 7/8] admin: document that structures can be shorter or longer Michael S. Tsirkin
2022-08-16 22:53 ` [virtio-comment] " Max Gurtovoy
2022-08-12 17:19 ` [PATCH RFC v7 8/8] admin command list discovery Michael S. Tsirkin
2022-08-16 23:06 ` Max Gurtovoy
2022-08-18 8:51 ` Jason Wang
2022-08-18 8:54 ` Michael S. Tsirkin
2022-08-18 8:56 ` [virtio-dev] " Zhu, Lingshan
2022-08-18 9:05 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812171841.12183-5-mst@redhat.com \
--to=mst@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=aadam@redhat.com \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=hang.yuan@intel.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=nrupal.jani@intel.com \
--cc=oren@nvidia.com \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox