From: Halil Pasic <pasic@linux.ibm.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org, hans@linux.alibaba.com,
herongguang@linux.alibaba.com, zmlcc@linux.alibaba.com,
dust.li@linux.alibaba.com, tonylu@linux.alibaba.com,
zhenzao@linux.alibaba.com, helinguo@linux.alibaba.com,
gerry@linux.alibaba.com, mst@redhat.com, cohuck@redhat.com,
jasowang@redhat.com, Jan Kiszka <jan.kiszka@siemens.com>,
wintera@linux.ibm.com, kgraul@linux.ibm.com,
wenjia@linux.ibm.com, jaka@linux.ibm.com, hca@linux.ibm.com,
twinkler@linux.ibm.com, raspl@linux.ibm.com,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism
Date: Wed, 11 Jan 2023 16:30:34 +0100 [thread overview]
Message-ID: <20230111163034.159a9eb5.pasic@linux.ibm.com> (raw)
In-Reply-To: <1673435333.1297436-1-xuanzhuo@linux.alibaba.com>
On Wed, 11 Jan 2023 19:08:53 +0800
Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > > +\begin{description}
> > > +\item[\field{ev_type}] The type of event, the driver can get the size of the
> > > + structure based on this.
> > > +
> > > +\item[\field{offset}] The offset of ism regions with the event.
> >
> > Offset with respect to what?
>
> Used to specify a region. Offset is the position of this ISM Region inside the
> memory of Device.
An offset is per definition always relative to something. I would have
thought this is an offset relative to the beginning of *the* virtio
shared memory region identified by the ismid 1. But since you claim that
there may be multiple virtio shared memory regions with the shmid 1 I'm
heavily confused. What is here "the memory of Device"?
next prev parent reply other threads:[~2023-01-11 15:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 8:13 [PATCH v2 0/1] introduce virtio-ism: internal shared memory device Xuan Zhuo
2022-12-23 8:13 ` [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism Xuan Zhuo
2023-01-10 22:34 ` [virtio-dev] " Halil Pasic
2023-01-11 11:08 ` Xuan Zhuo
2023-01-11 15:11 ` Halil Pasic
2023-01-12 2:01 ` Jason Wang
2023-01-12 6:56 ` Michael S. Tsirkin
2023-01-12 8:42 ` Cornelia Huck
2023-01-12 11:48 ` Xuan Zhuo
2023-01-12 14:30 ` Cornelia Huck
2023-01-12 15:41 ` Halil Pasic
2023-01-12 16:07 ` Cornelia Huck
2023-01-13 1:58 ` Xuan Zhuo
2023-01-13 2:29 ` Jason Wang
2023-01-13 6:24 ` Xuan Zhuo
2023-01-13 12:00 ` Michael S. Tsirkin
2023-01-16 2:10 ` Xuan Zhuo
2023-01-19 12:30 ` Alexandra Winter
2023-01-28 7:42 ` Xuan Zhuo
2023-01-12 11:47 ` Xuan Zhuo
2023-01-12 12:15 ` Halil Pasic
2023-01-11 15:22 ` Halil Pasic
2023-01-12 11:57 ` Xuan Zhuo
2023-01-11 15:30 ` Halil Pasic [this message]
2023-01-12 12:03 ` Xuan Zhuo
2023-01-11 20:46 ` Halil Pasic
2023-01-12 12:23 ` Xuan Zhuo
2023-01-11 21:12 ` Halil Pasic
2023-01-12 7:01 ` Michael S. Tsirkin
2023-01-12 12:31 ` Xuan Zhuo
2023-01-20 13:06 ` Halil Pasic
2023-01-12 12:40 ` Xuan Zhuo
2023-02-05 12:30 ` Michael S. Tsirkin
2023-02-06 2:15 ` Xuan Zhuo
2023-01-25 12:55 ` [PATCH v2 0/1] introduce virtio-ism: internal shared memory device Wenjia Zhang
2023-03-01 9:34 ` Tony Lu
2023-03-01 9:34 ` [virtio-dev] " Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111163034.159a9eb5.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=dust.li@linux.alibaba.com \
--cc=gerry@linux.alibaba.com \
--cc=hans@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=helinguo@linux.alibaba.com \
--cc=herongguang@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=kgraul@linux.ibm.com \
--cc=mst@redhat.com \
--cc=raspl@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=twinkler@linux.ibm.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=zhenzao@linux.alibaba.com \
--cc=zmlcc@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox