Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Parav Pandit <parav@nvidia.com>,
	virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org, david@redhat.com
Subject: Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files
Date: Fri, 13 Jan 2023 06:42:27 -0500	[thread overview]
Message-ID: <20230113064057-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87bkn2ohx3.fsf@redhat.com>

On Fri, Jan 13, 2023 at 11:19:52AM +0100, Cornelia Huck wrote:
> On Thu, Jan 12 2023, Parav Pandit <parav@nvidia.com> wrote:
> 
> > Relatively several of the recent device specifications are maintained
> > in their own specification file. Such separate files enables better
> > maintenance of the specification overall.
> > However, several of the initial virtio device specifications
> > are located in single file.
> >
> > Hence, split them into their individual files.
> >
> > Additionally, each device's driver and device conformance is
> > present in one giant conformance file all together.
> >
> > As Michael suggest's move this device and driver conformance
> > section adjacent to device specification in each device specific
> > directory. This further makes device specification self-contained.
> >
> > Added patch to fix spelling errors in network device
> > specification which was inherited from its previous file
> > location.
> >
> > Patches do not change any part of the specification outcome
> > except fixing the spelling errors.
> > It only changes how the specification is maintained.
> >
> > patch summary:
> > -------------
> > patch 1 to 7 creates new files for moving devices spec out of
> > content and conformance files.
> > patch 8 to 20 move existing dedicated file spec to new directory
> > and creates per device,driver conformance file for each device.
> 
> This LGTM now.
> 
> Michael: did you check whether redlining works as expected?

I have successfully generated a diff from 1.1 and did some manual
spot checking. Looks ok to me.  I really expect contributors to
do this too :)


  reply	other threads:[~2023-01-13 11:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 21:22 [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files Parav Pandit
2023-01-12 21:22 ` [PATCH v4 01/20] virtio-net: Maintain network device spec in separate directory Parav Pandit
2023-01-12 21:22 ` [virtio-comment] [PATCH v4 02/20] virtio-net: Fix spelling errors Parav Pandit
2023-01-12 21:22 ` [PATCH v4 03/20] virtio-blk: Maintain block device spec in separate directory Parav Pandit
2023-01-12 21:22 ` [PATCH v4 04/20] virtio-console: Maintain console " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 05/20] virtio-entropy: Maintain entropy " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 06/20] virtio-mem-balloon: Maintain mem balloon " Parav Pandit
2023-01-13 10:53   ` David Hildenbrand
2023-01-12 21:22 ` [PATCH v4 07/20] virtio-scsi: Maintain scsi host " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 08/20] virtio-gpu: Maintain gpu " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 09/20] virtio-input: Maintain input " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 10/20] virtio-crypto: Maintain crypto " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 11/20] virtio-vsock: Maintain socket " Parav Pandit
2023-01-13 10:28   ` [virtio-comment] " Stefano Garzarella
2023-01-12 21:22 ` [PATCH v4 12/20] virtio-fs: Maintain file system " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 13/20] virtio-rpmb: Maintain rpmb " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 14/20] virtio-iommu: Maintain iommu " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 15/20] virtio-sound: Maintain sound " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 16/20] virtio-mem: Maintain memory " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 17/20] virtio-i2c: Maintain i2c " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 18/20] virtio-scmi: Maintain scmi " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 19/20] virtio-gpio: Maintain gpio " Parav Pandit
2023-01-12 21:22 ` [PATCH v4 20/20] virtio-pmem: Maintain pmem " Parav Pandit
2023-01-13 10:19 ` [virtio-dev] Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files Cornelia Huck
2023-01-13 11:42   ` Michael S. Tsirkin [this message]
2023-01-13 13:42     ` Parav Pandit
2023-01-13 11:44 ` Michael S. Tsirkin
2023-01-13 12:26 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113064057-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox