[virtio-comment] Re: [virtio-dev] [PATCH v2] virtio_net: support low and high rate of notification coalescing

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jan 17, 2023 at 03:03:43PM +0200, Alvaro Karsz wrote:
> > By comparison this patch is an attempt to offload ethtool's
> > --coalesce parameters to the card. IMO what it misses is
> > completeness, e.g. sample-interval is not specified.
> 
> AFAIK sample-interval refers to the adaptive coalescing
> (adaptive-rx/adaptive-tx) and not to high/low.
> 
> include/uapi/linux/ethtool.h:
>  * @rate_sample_interval: How often to do adaptive coalescing packet rate
>  * sampling, measured in seconds.  Must not be zero.

Oh you are right. So sampling interval here is arbitrary,
defined by the device. Worth documenting.

> > Also, introspection is missing and it's useful to avoid
> > keeping all state in the driver.
> 
> I don't get it, can you please elaborate?

I mean --show-coalesce

-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/