Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: mst@redhat.com, virtio-dev@lists.oasis-open.org, cohuck@redhat.com
Cc: virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
	Parav Pandit <parav@nvidia.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: [PATCH] virtio-net: Avoid confusing device configuration text
Date: Thu, 26 Jan 2023 02:31:39 +0200	[thread overview]
Message-ID: <20230126003139.1185666-1-parav@nvidia.com> (raw)

The added text in commit of Fixes tag was redundant and
confusing in context of VLAN filtering description.

Hence remove it as discussed in [1] and [2].

[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.html

Fixes: 296303444f6b ("virtio-net: Clarify VLAN filter table configuration")
Suggested-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
This change is on top of [3].

[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html
---
 device-types/net/description.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index e32780b..bd81731 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering}
 
 When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST
-accept all VLAN tagged packets as per the device configuration.
+accept all VLAN tagged packets.
 
 When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST
 accept all VLAN tagged packets whose VLAN tag is present in
-- 
2.26.2


             reply	other threads:[~2023-01-26  0:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26  0:31 Parav Pandit [this message]
2023-01-30 11:26 ` [virtio-dev] Re: [PATCH] virtio-net: Avoid confusing device configuration text Cornelia Huck
2023-01-30 11:27 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126003139.1185666-1-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox