From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: parav@nvidia.com, jasowang@redhat.com,
virtio-comment@lists.oasis-open.org, hengqi@linux.alibaba.com,
virtio-dev@lists.oasis-open.org
Subject: [virtio-dev] Re: [PATCH v2] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature
Date: Mon, 13 Feb 2023 06:12:53 -0500 [thread overview]
Message-ID: <20230213061238-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_AtbBdtceGvUa6tsiCRKgpYg+nOibJ0eoA9h9u3fKJ5cA@mail.gmail.com>
On Mon, Feb 13, 2023 at 10:33:32AM +0200, Alvaro Karsz wrote:
> Splitting this patch as suggested in v1 will be messy,
>
> We have lines affected by multiple changes, for example:
>
> +\item VIRTIO_NET_CTRL_NOTF_COAL_RX_SET: set the \field{usecs} and
> \field{max_packets} parameters for all the receive virtqueues.
>
> Is affected by the consolidation of the structs and by the statement
> that the command should apply to all virtqueues.
>
> Do you think that this is ok to keep it as a single patch that makes
> multiple minor changes?
It is reasonably small so maybe ok.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-02-13 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 8:30 [virtio-dev] [PATCH v2] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature Alvaro Karsz
2023-02-13 8:33 ` [virtio-comment] " Alvaro Karsz
2023-02-13 11:12 ` Michael S. Tsirkin [this message]
2023-02-13 11:12 ` Michael S. Tsirkin
2023-02-13 12:04 ` [virtio-dev] " Alvaro Karsz
2023-02-13 12:36 ` Michael S. Tsirkin
2023-02-13 13:43 ` Alvaro Karsz
2023-02-13 14:21 ` Michael S. Tsirkin
2023-02-13 15:05 ` [virtio-comment] " Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213061238-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox