From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Parav Pandit <parav@nvidia.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: Re: [PATCH] content.tex Fix Driver notifications label
Date: Wed, 15 Feb 2023 07:59:58 -0500 [thread overview]
Message-ID: <20230215075915-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <871qmrdstu.fsf@redhat.com>
On Wed, Feb 15, 2023 at 01:19:25PM +0100, Cornelia Huck wrote:
> On Wed, Feb 15 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Fri, Feb 10, 2023 at 12:23:14PM +0100, Cornelia Huck wrote:
> >> On Fri, Feb 03 2023, Parav Pandit <parav@nvidia.com> wrote:
> >>
> >> > Driver notifications section is under "Basic Facilities of a Virtio
> >> > Device". However, the label is placed under "Virtqueues" section.
> >> >
> >> > Fix the label references.
> >> >
> >> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> >> > ---
> >> > content.tex | 14 +++++++-------
> >> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >>
> >> Not sure if it was originally intended to sit unter the virtqueues
> >> section (it was lifted up one level as it disappeared under the packet
> >> ring section), might have been.
> >>
> >> It probably makes sense to not try and move it back into the virtqueues
> >> section, and instead do your change. Other opinions?
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Minor fix does not need a vote.
> > Cornelia are you applying this?
>
> Pushed.
btw did you try to generate a diff pdf? when changing labels it is
sometimes necessary to keep old ones around too as diff
needs old and new links to work.
--
MST
next prev parent reply other threads:[~2023-02-15 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 18:35 [PATCH] content.tex Fix Driver notifications label Parav Pandit
2023-02-10 11:23 ` [virtio-dev] " Cornelia Huck
2023-02-15 5:31 ` Parav Pandit
2023-02-15 11:14 ` Michael S. Tsirkin
2023-02-15 12:19 ` [virtio-comment] " Cornelia Huck
2023-02-15 12:59 ` Michael S. Tsirkin [this message]
2023-02-15 15:08 ` Cornelia Huck
2023-02-15 21:53 ` Parav Pandit
2023-02-16 0:20 ` Michael S. Tsirkin
2023-02-16 5:36 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215075915-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox