[virtio-dev] Re: [virtio-comment] Re: [PATCH v4] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Feb 16, 2023 at 10:40:10AM +0200, Alvaro Karsz wrote:
> Hi Heng,
> 
> > > +When the device has non-zero \field{usecs} and non-zero \field{max_packets}, it starts counting usecs and packets upon receiving/sending a packet.
> > > +The device counts packets and usecs for each receive virtqueue and transmit virtqueue separately.
> > > +In this case, the notification conditions are met when \field{usecs} usecs elapses, or upon sending/receiving \field{max_packets} packets, whichever happens first.
> > > +
> >
> > Hi, Alvaro.
> >
> > "when \field{usecs} usecs elapses"  --> "when \field{usecs} elapses", right?
> 
> Actually, no.
> \field{usecs} refers to the field in the struct.
> usecs refers to the units of measurement.
> 
> So if for example \field{usecs} = 40, then it evaluates to 40 usecs ->
> "are met when 40 usecs elapses".

But this is not how it reads, people are not computers, and in the
compiled PDF \field{usec} just looks as usecs in italics.

> I can change the field name in the struct to "max_usecs" if people
> think it's necessary.

Maybe that's a good idea.

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org