From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [PATCH v2] virtio-net: Define configuration field layout before its description
Date: Fri, 17 Feb 2023 04:31:05 -0500 [thread overview]
Message-ID: <20230217042935-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481AD3ECF5D89295AF8395DDCA19@PH0PR12MB5481.namprd12.prod.outlook.com>
On Fri, Feb 17, 2023 at 01:20:42AM +0000, Parav Pandit wrote:
>
>
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Wednesday, February 8, 2023 11:52 PM
> >
> > Currently some fields of the virtio_net_config structure are defined before
> > introducing the structure and some are defined after introducing
> > virtio_net_config.
> > Better to define the configuration layout first followed by description of all the
> > fields.
> >
> > Device configuration fields are described in the section. Change wording from
> > 'listed' to 'described' as suggested in patch [1].
> >
> > While rewording the configuration layout, mention only one time that all the
> > fields of the configuration layout are read-only. Remove read-only wording
> > from individual fields.
> >
> > [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00004.html
> >
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> > changelog:
> > v1->v2:
> > - remove read-only wording from multiple places
>
> Since there are no further comments, can you please take this further?
Sorry about the delay, responded now.
> It is only editorial change.
It's a bit on the border for minor corrections. But I feel
we really should add a normative statement too, and that
will probably push it into the "need a vote" territory.
next prev parent reply other threads:[~2023-02-17 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 4:52 [PATCH v2] virtio-net: Define configuration field layout before its description Parav Pandit
2023-02-17 1:20 ` Parav Pandit
2023-02-17 9:31 ` Michael S. Tsirkin [this message]
2023-02-17 9:29 ` Michael S. Tsirkin
2023-02-17 14:03 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217042935-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox