Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Parav Pandit <parav@nvidia.com>,
	virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org,
	Jason Wang <jasowang@redhat.com>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-dev] Re: [PATCH v10] virtio-net: support inner header hash
Date: Wed, 15 Mar 2023 11:09:56 -0400	[thread overview]
Message-ID: <20230315110736-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <e573702a-9a2e-d210-f13a-f0b241442991@linux.alibaba.com>

On Wed, Mar 15, 2023 at 09:19:43PM +0800, Heng Qi wrote:
> > Any encapsulation technology that includes UDP/L4 header likely do not
> > prefer based on the inner header. This is because the outer header src
> > port entropy is added based on the inner header.
> > 
> > I was not able to follow the discussion in v9 that you had with Michael.
> > Did you conclude if this is needed for vxlan too?
> > 
> > If not, for now it may be better to skip vxlan and nvegre as they
> > inherently have unique outer header UDP src port based on the inner
> > header.
> 
> Symmetric hashing ignores the order of the five-tuples when calculating the
> hash, that is, using (a1,a2,p1,p2) and (a2,a1,p2,p1) respectively can
> calculate the same hash.
> There is a scenario that the two directions client1->client2 and
> client2->client1 of the same flow may pass through different tunnels.
> In order to allow the data in two directions to be processed by the same
> CPU, we need to calculate a symmetric hash based on the inner packet header.
> Sorry I didn't mention this earlier just to avoid introducing the concept of
> symmetric hashing.

But the hash is already there in the port. Is it then maybe just
the question of ignoring the IP addresses when hashing?

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-03-15 15:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 15:48 [virtio-dev] [PATCH v10] virtio-net: support inner header hash Heng Qi
2023-03-08 14:27 ` Heng Qi
2023-03-08 14:31   ` Michael S. Tsirkin
2023-03-14 13:59 ` [virtio-dev] " Heng Qi
2023-03-15  3:23 ` Parav Pandit
2023-03-15 12:10   ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-03-15 13:27     ` Heng Qi
2023-03-15 23:24     ` Parav Pandit
2023-03-16  7:36       ` Michael S. Tsirkin
2023-03-16 18:45         ` [virtio-dev] " Parav Pandit
2023-03-16 13:45       ` [virtio-dev] " Heng Qi
2023-03-15 13:19   ` [virtio-dev] " Heng Qi
2023-03-15 15:09     ` Michael S. Tsirkin [this message]
2023-03-16 13:26       ` Heng Qi
2023-03-15 23:06     ` Parav Pandit
2023-03-16 13:38       ` [virtio-dev] Re: [virtio-comment] " Heng Qi
2023-03-16 19:55         ` [virtio-dev] " Parav Pandit
2023-03-17  8:38           ` Heng Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315110736-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox