From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
cohuck@redhat.com, sgarzare@redhat.com, nrupal.jani@intel.com,
Piotr.Uminski@intel.com, hang.yuan@intel.com,
virtio@lists.oasis-open.org, Jiri Pirko <jiri@nvidia.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
pasic@linux.ibm.com, Shahaf Shuler <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [PATCH v11 08/10] admin: command list discovery
Date: Tue, 4 Apr 2023 08:57:45 -0400 [thread overview]
Message-ID: <20230404125745.GE428487@fedora> (raw)
In-Reply-To: <84cf421ad95111b37cddb52b2a7bf625b7955ae6.1680533760.git.mst@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
On Mon, Apr 03, 2023 at 11:03:49AM -0400, Michael S. Tsirkin wrote:
> Add commands to find out which commands does each group support,
> as well as enable their use by driver.
> This will be especially useful once we have multiple group types.
>
> An alternative is per-type VQs. This is possible but will
> require more per-transport work. Discovery through the vq
> helps keep things contained.
>
> e.g. lack of support for some command can switch to a legacy mode
>
> note that commands are expected to be avolved by adding new
> fields to command specific data at the tail, so
> we generally do not need feature bits for compatibility.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ---
> dropped S.O.B by Max
> explain in commit log how commands will evolve, comment by Stefan
> replace will use with is capable of use, comment by Stefan
> typo fix reported by David and Lingshan
> rename cmds to cmd_opcodes suggested by Jiri
> list group_type explicitly in command description suggested by Jiri
> clarify how can device not support some commands
> always say group administration commands, comment by Jiri
> ---
> admin.tex | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 101 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-04 12:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:02 [virtio-dev] [PATCH v11 00/10] Introduce device group and device management Michael S. Tsirkin
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 01/10] virtio: document forward compatibility guarantees Michael S. Tsirkin
2023-04-06 7:15 ` [virtio-dev] " Zhu, Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 02/10] admin: introduce device group and related concepts Michael S. Tsirkin
2023-04-04 11:38 ` [virtio-dev] " Stefan Hajnoczi
2023-04-06 3:42 ` Parav Pandit
2023-04-10 13:23 ` Michael S. Tsirkin
2023-04-10 16:42 ` [virtio-dev] " Parav Pandit
2023-04-24 16:30 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-24 16:45 ` [virtio-dev] RE: [virtio] " Parav Pandit
2023-04-24 20:32 ` [virtio-dev] " Michael S. Tsirkin
2023-04-06 7:16 ` [virtio-dev] " Zhu, Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 03/10] admin: introduce group administration commands Michael S. Tsirkin
2023-04-04 11:50 ` [virtio-dev] " Stefan Hajnoczi
2023-04-06 3:58 ` Parav Pandit
2023-04-06 7:16 ` Zhu, Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 04/10] admin: introduce virtio admin virtqueues Michael S. Tsirkin
2023-04-04 11:58 ` [virtio-dev] " Stefan Hajnoczi
2023-04-06 4:08 ` Parav Pandit
2023-04-10 13:22 ` Michael S. Tsirkin
2023-04-10 14:22 ` [virtio-dev] " Parav Pandit
2023-04-10 20:04 ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 13:39 ` [virtio-dev] " Parav Pandit
2023-04-11 14:01 ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 15:46 ` [virtio-dev] " Parav Pandit
2023-04-06 7:17 ` [virtio-dev] " Zhu Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 05/10] pci: add admin vq registers to virtio over pci Michael S. Tsirkin
2023-04-04 12:52 ` [virtio-dev] " Stefan Hajnoczi
2023-04-06 4:14 ` Parav Pandit
2023-04-24 15:36 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-06 7:17 ` [virtio-dev] Re: [virtio] " Zhu, Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 06/10] mmio: document ADMIN_VQ as reserved Michael S. Tsirkin
2023-04-03 15:54 ` [virtio-dev] " Parav Pandit
2023-04-24 15:38 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-06 7:18 ` [virtio-dev] Re: [virtio-comment] " Zhu Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 07/10] ccw: " Michael S. Tsirkin
2023-04-03 15:55 ` [virtio-dev] " Parav Pandit
2023-04-03 17:29 ` Michael S. Tsirkin
2023-04-06 4:15 ` Parav Pandit
2023-04-06 7:18 ` [virtio-dev] " Zhu Lingshan
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 08/10] admin: command list discovery Michael S. Tsirkin
2023-04-04 12:57 ` Stefan Hajnoczi [this message]
2023-04-06 4:27 ` [virtio-dev] " Parav Pandit
2023-04-24 16:13 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-06 7:20 ` [virtio-dev] " Zhu Lingshan
2023-04-06 14:05 ` Parav Pandit
2023-04-07 2:01 ` Zhu, Lingshan
2023-04-07 7:34 ` Michael S. Tsirkin
2023-04-03 15:03 ` [virtio-dev] [PATCH v11 09/10] admin: conformance clauses Michael S. Tsirkin
2023-04-04 13:03 ` [virtio-dev] " Stefan Hajnoczi
2023-04-06 7:30 ` [virtio-dev] Re: [virtio] " Zhu, Lingshan
2023-04-24 16:17 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-03 15:04 ` [virtio-dev] [PATCH v11 10/10] ccw: document more reserved features Michael S. Tsirkin
2023-04-06 7:31 ` [virtio-dev] Re: [virtio-comment] " Zhu Lingshan
2023-04-03 15:59 ` [virtio-dev] Re: [PATCH v11 00/10] Introduce device group and device management Parav Pandit
2023-04-03 16:39 ` Cornelia Huck
2023-04-03 17:31 ` Michael S. Tsirkin
2023-04-04 8:10 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404125745.GE428487@fedora \
--to=stefanha@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=cohuck@redhat.com \
--cc=hang.yuan@intel.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=nrupal.jani@intel.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox