From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4F25C77B61 for ; Mon, 10 Apr 2023 06:40:00 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 1359A2B016 for ; Mon, 10 Apr 2023 06:40:00 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EAEBE98636E for ; Mon, 10 Apr 2023 06:39:59 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id D7AC09862A5; Mon, 10 Apr 2023 06:39:59 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C535598631E for ; Mon, 10 Apr 2023 06:39:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: 0yWbsATQOHyVUM1-J-jdNQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681108796; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ik+K7A8ZeoFVyvZHa5hPdNmVX/txp+CzssG24WtYK4Q=; b=RRg+FHMv+BxhYguK+xO0ZNbaLF1PGz1Yt0lhLCIzm8KpfIJ0ttU+W+eK3fXOf03XzA h7QWrjODK0QFhTvclA/uQAPRDrKSXR22ozR+vYuQmFDdJc/rSLtpXi8kxlxtYVVJ92Pu Fc7Pu0ahKP2LbDY4CF2/ISJW1HZyVYxuto6GAQ1PNhRsWw/rQHkaNU80+VUawLtz3y7T HNtwz8oU2QqaoGFl/qF3Y7XaW+kikiiBgqEpp4OEJb3+jg6KNZt5iuGMVyuDIOWCaEAD bQjlGL4+uNFha4+N5xV2Xf9x43/mcgx68nSd/qaC0Vuvk5ff7ux3Xbrb2nqnYQWmzyWH +xhg== X-Gm-Message-State: AAQBX9eM0Y8U0Kk6OfHe4B+e46SDSzeZyDQyQeRj1QCMpIq8uSZpOIZk Vq3obCyyEYL3kYfVjZjEKnm9zoR1bSwDHfz9e+3V28XmpIp36zVALFFwpUy/wgQGuF+yKcSR0vs 7NnMuZ5XEM4aj1kwk+A7hFloEhljl X-Received: by 2002:adf:f909:0:b0:2d2:f3e3:115d with SMTP id b9-20020adff909000000b002d2f3e3115dmr6769584wrr.59.1681108796760; Sun, 09 Apr 2023 23:39:56 -0700 (PDT) X-Google-Smtp-Source: AKy350YdYJWupf8UeJ1GsVtPu9FBERPwuXrlWOi24LmR2B1Nk3a/sNKHhY5eSqG/Hz2BvHEybuB2gQ== X-Received: by 2002:adf:f909:0:b0:2d2:f3e3:115d with SMTP id b9-20020adff909000000b002d2f3e3115dmr6769569wrr.59.1681108796482; Sun, 09 Apr 2023 23:39:56 -0700 (PDT) Date: Mon, 10 Apr 2023 02:39:52 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Parav Pandit , virtio-dev@lists.oasis-open.org, cohuck@redhat.com, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com, Satananda Burla Message-ID: <20230410023715-mutt-send-email-mst@kernel.org> References: <20230330225834.506969-1-parav@nvidia.com> <20230330225834.506969-10-parav@nvidia.com> <20230407043841-mutt-send-email-mst@kernel.org> <20230410020906-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Subject: [virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers On Mon, Apr 10, 2023 at 02:20:16PM +0800, Jason Wang wrote: > On Mon, Apr 10, 2023 at 2:15 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 10, 2023 at 09:33:32AM +0800, Jason Wang wrote: > > > This is fine for vDPA but not for virtio if the design can only work > > > for some specific setups (OSes/archs). > > > > > > Thanks > > > > Well virtio legacy has a long history of documenting existing hacks :) > > Exactly, so the legacy behaviour is not (or can't be) defined by the > spec but the codes. I mean driver behaviour derives from the code but we do document it in the spec to help people build devices. > > But yes, VIRTIO_F_ORDER_PLATFORM has to be documented. > > And we have to decide what to do about ACCESS_PLATFORM since > > there's a security problem if device allows not acking it. > > Two options: > > - relax the rules a bit and say device will assume ACCESS_PLATFORM > > is acked anyway > > This will break legacy drivers which assume physical addresses. not that they are not already broken. > > - a new flag that is insecure (so useful for sec but useless for dpdk) but optional > > This looks like a new "hack" for the legacy hacks. it's not just for legacy. > And what about ORDER_PLATFORM, I don't think we can modify legacy drivers... > > Thanks You play some tricks with shadow VQ I guess. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org