From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC38FC77B73 for ; Wed, 19 Apr 2023 07:08:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 5A98A3DF2F for ; Wed, 19 Apr 2023 07:08:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 435CA986434 for ; Wed, 19 Apr 2023 07:08:34 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 2B26D986416; Wed, 19 Apr 2023 07:08:34 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 18B9498641B for ; Wed, 19 Apr 2023 07:08:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: yzYGHy6vNguunjYiZbUwuA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681888111; x=1684480111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bg0BqieMlM0sWcdkoZ3rrzy9NBLkf+vYo2CqcpS7crM=; b=VvUZtOsSS8dTYeUHZOQuUBaDJXiWuL5BHoSZu6p9CIQO4TTPuRdTfaiWBxi8IUFc1E va88PR2cq8ySzMAWxzBy/lHMSSvqa1/BhTdROEUtA0+Mn7w7iQW8ff30FeTqZa1yMuz5 G7tbxTYX4dpQB03rewNnuM+jSog6hu0PmTaRAk91gGNajoDSBS2ZfTvxEVUtRW1GNcBl SVhsYCZ8aVP14+D6RvpN87nsoiHXdsH9mYTR00XvndWF+BM5gi6Ofx+X/mpNZ/QjRZIO geVd+GnmtAorRrpr8S+rTLJ338H8E1dGorXYdooTbCeApPQa6jZyo10qirmBB/F7MCE/ dHwg== X-Gm-Message-State: AAQBX9ffRhzfg5SVyHZ20RmbWyEnX0I8l1QsWb5wPg9QIFYsWKP1cNr4 grC88fzBeRUhcNWn949dECxj79k0tkZs3gB7qqC+k0CIINZMBBO1OyUOErargWugt8c+5NyipJG VrTaGSfAYvO95weFmabq1OL+YQxS85wd/oYiR X-Received: by 2002:a7b:c049:0:b0:3f1:7dc0:7fa5 with SMTP id u9-20020a7bc049000000b003f17dc07fa5mr1686125wmc.26.1681888110763; Wed, 19 Apr 2023 00:08:30 -0700 (PDT) X-Google-Smtp-Source: AKy350aoLiv8kQfgsfwrFAeChwLk8hjwFD4FXqwMSLHCNVeoyDbgGnUNBxhF79KQkG8A7xYG4vK9VA== X-Received: by 2002:a7b:c049:0:b0:3f1:7dc0:7fa5 with SMTP id u9-20020a7bc049000000b003f17dc07fa5mr1686105wmc.26.1681888110492; Wed, 19 Apr 2023 00:08:30 -0700 (PDT) Date: Wed, 19 Apr 2023 03:08:25 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: virtio-dev@lists.oasis-open.org, pasic@linux.ibm.com, cohuck@redhat.com, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com, Max Gurtovoy Message-ID: <20230419030514-mutt-send-email-mst@kernel.org> References: <20230411194220.752355-1-parav@nvidia.com> <20230411194220.752355-3-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20230411194220.752355-3-parav@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH 2/2] transport-pci: Improve queue msix vector register desc On Tue, Apr 11, 2023 at 10:42:20PM +0300, Parav Pandit wrote: > queue_msix_vector register is for receiving interrupts from the device > for the virtqueue. > > "for MSI-X" is confusing term. > > Also it is the register that driver "writes" to, similar to > many other registers such as queue_desc, queue_driver etc. > > Hence, replace the verb from use to write. > > Signed-off-by: Parav Pandit > Reviewed-by: Max Gurtovoy > --- > changelog: > v0->v1: > - added 'here' > - dropped 'receiving' > --- > transport-pci.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/transport-pci.tex b/transport-pci.tex > index cb9fadd..00669b5 100644 > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -367,7 +367,7 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport > A 0 means the queue is unavailable. > > \item[\field{queue_msix_vector}] > - The driver uses this to specify the queue vector for MSI-X. > + The driver writes an MSI-X vector number here for virtqueue interrupts. Here it's *the* specific queue not just some queue. And in fact we call them virtqueue notifications, not interrupts elsewhere. So how about: Used by the driver to set the MSI-X vector number for the virtqueue notifications. > \item[\field{queue_enable}] > The driver uses this to selectively prevent the device from executing requests from this virtqueue. > -- > 2.26.2 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org