From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A0F5C77B73 for ; Thu, 20 Apr 2023 20:44:52 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 17E2C2AC58 for ; Thu, 20 Apr 2023 20:44:51 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 0B9AC98663F for ; Thu, 20 Apr 2023 20:44:51 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 0065798634C; Thu, 20 Apr 2023 20:44:51 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id E42B89863EA for ; Thu, 20 Apr 2023 20:44:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: tn7PFVFKMEyrV5JDZ0hPNQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682023483; x=1684615483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ou7o0LBEJbCsMdVRUWkMvR54beMz0R6KoLvZHE59x3s=; b=cQZIZSHFI5cxGRXu1qTmAM1jHQVefiiCdd6V5A9BioTbu4Gt0QLj0OqnrBON/81EX4 ewfNGLTVcdMrPCouBYf/veFk/e46hIUDm1oQKrECGLwjRZtK/NwUOEsBiOzFC6TIOU9Z S3dUFCDYNdLk8HHj51zpFtRmXXz2aqijns+movMWJRyAIu71HUXwJOVVHM9ynCZTOAlo qJcgwJQFuSrDhIKHvQWOJuCRhOjbvBscSKGdobymEdEYbceUw0HzCGNCEVPaMx0kAjnk my9H5oVONiZBhDs+livFpz4Yz2omT5+E5rXdnT4GKAq42rrnbRYdJfkbT11C4TEELdJT AF5g== X-Gm-Message-State: AAQBX9dZggsHbBT7F8tW1xhabET1l/3ksP/S4wH1tUgZpMyrDKKL4C5w It1JGMX4VlgYHwxnkQ1EpyWDKN1GWLWQE3Cb2RcF0l9OsSd3PL+FuikQ4HkkYEl0veP+vxKNtdH siba+bgMxteZuEwv+deyQ0CFMr5IWFXkoeQu5T9k= X-Received: by 2002:adf:fb49:0:b0:303:6209:65f4 with SMTP id c9-20020adffb49000000b00303620965f4mr301909wrs.38.1682023483089; Thu, 20 Apr 2023 13:44:43 -0700 (PDT) X-Google-Smtp-Source: AKy350a1aFK9ZnZ26ik+dOz4tp5qiKYAAkvdRdXewzZxi9WZaIpoD2NGYCvejeJIpnOfu5qvF4eNFg== X-Received: by 2002:adf:fb49:0:b0:303:6209:65f4 with SMTP id c9-20020adffb49000000b00303620965f4mr301896wrs.38.1682023482675; Thu, 20 Apr 2023 13:44:42 -0700 (PDT) Date: Thu, 20 Apr 2023 16:44:38 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: virtio-dev@lists.oasis-open.org, pasic@linux.ibm.com, cohuck@redhat.com, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com, Max Gurtovoy Message-ID: <20230420163800-mutt-send-email-mst@kernel.org> References: <20230420195158.69737-1-parav@nvidia.com> <20230420195158.69737-2-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20230420195158.69737-2-parav@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] [PATCH 1/2] transport-pci: Improve config msix vector description On Thu, Apr 20, 2023 at 10:51:57PM +0300, Parav Pandit wrote: > config_msix_vector is the register that holds the MSI-X vector number > for receiving configuration change related interrupts. > > It is not "for MSI-X". > > Hence, replace the confusing text with appropriate one. > > Reviewed-by: Max Gurtovoy > Signed-off-by: Parav Pandit it's unfortunate that the pci spec does not have a standard term for msi-x table entry. > --- > changelog: > v1->v2: > - rewrote to indicate MSI-X table entry index > v0->v1: > - added 'here' > - dropped 'receiving' > --- > transport-pci.tex | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/transport-pci.tex b/transport-pci.tex > index 1507c69..cf2c54d 100644 > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -343,7 +343,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport > Driver Feature Bits selected by \field{driver_feature_select}. > > \item[\field{config_msix_vector}] > - The driver sets the Configuration Vector for MSI-X. > + The driver writes the MSI-X table entry index in this field for > + Configuration change notification interrupts. Urm not exactly. there is also a special value of 0xffff. I feel this here is just a high level description. how about Used by the driver to set the MSI-X vector for Configuration change notification interrupts. pci spec also calls the entry "the vector" so I feel it's ok. > \item[\field{num_queues}] > The device specifies the maximum number of virtqueues supported here. > -- > 2.26.2 > > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/ --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org