From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76BB5C77B73 for ; Thu, 20 Apr 2023 20:45:26 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id B9B643DF26 for ; Thu, 20 Apr 2023 20:45:25 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id B0EC6986642 for ; Thu, 20 Apr 2023 20:45:25 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id A68109863EA; Thu, 20 Apr 2023 20:45:25 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 91C0698634C for ; Thu, 20 Apr 2023 20:45:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: dUVqTLq2OUqT4ktIveaA4Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682023518; x=1684615518; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D7U2LoKrZy4IEtp5AzShio0G6dowEwJFp0f5PqxF3TY=; b=RNvtxxmFPpWXxJWcnmt5YUWfvpX+49Yc1v7up/uNwYcr1y+GaIi8qqjJCSSj6m7UIX jh0bc2kX7n/sSe6+Nt3epdGwWUH+3OIaVFVsSOsH8VG0l7DwUlxoNxYkAOmF1c1oxLJC 7vJ0pyB/g4q+Bgv5OKMCootgwBwjZQY0WBbehk4ioOAGA2gSH7ayQLKcahEa8oESant/ tI6cIauL0IUMMOqExB2mYfpjXIdsx6ZFrfw8xy1FfXH8idQxao6asI9hzimEU6+9uoAw xt0PFprReJ2dOkDOCJbBo600Uu/fVWuaB+eZ4LldfqV8JdMpgguBsWw51yi5RE/02iXZ CA/Q== X-Gm-Message-State: AAQBX9fEAr0zXaJQsmmNgyprdGkpnhgQU6mACZNhaFcPde8gpIBFo7G6 4LBzXGKpq27yCSTa9gOc7UnrxuyjjojkGyUzrxedqx6TbHeZGSMnes/a+7vLbRsKoi/xRS3GQVQ MgbKLcG669xlyF+ThOIJzXM7a5e9h X-Received: by 2002:adf:dd85:0:b0:2d1:9c50:5746 with SMTP id x5-20020adfdd85000000b002d19c505746mr2105961wrl.12.1682023518335; Thu, 20 Apr 2023 13:45:18 -0700 (PDT) X-Google-Smtp-Source: AKy350beRLfs/rjDxfIy7JhfPgWXj2hSc0hucgKBktgUVgnK/EuS4Oztda6jASzyAdmpjfW0C93+mA== X-Received: by 2002:adf:dd85:0:b0:2d1:9c50:5746 with SMTP id x5-20020adfdd85000000b002d19c505746mr2105953wrl.12.1682023518083; Thu, 20 Apr 2023 13:45:18 -0700 (PDT) Date: Thu, 20 Apr 2023 16:45:14 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: virtio-dev@lists.oasis-open.org, pasic@linux.ibm.com, cohuck@redhat.com, virtio-comment@lists.oasis-open.org, shahafs@nvidia.com, Max Gurtovoy Message-ID: <20230420164508-mutt-send-email-mst@kernel.org> References: <20230420195158.69737-1-parav@nvidia.com> <20230420195158.69737-3-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20230420195158.69737-3-parav@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH 2/2] transport-pci: Improve queue msix vector register desc On Thu, Apr 20, 2023 at 10:51:58PM +0300, Parav Pandit wrote: > queue_msix_vector register is for receiving virtqueue notification > interrupts from the device for the virtqueue. > > "for MSI-X" is confusing term. > > Also it is the register that driver "writes" to, similar to > many other registers such as queue_desc, queue_driver etc. > > Hence, replace the verb from use to write. > > Signed-off-by: Parav Pandit > Reviewed-by: Max Gurtovoy > --- > changelog: > v1->v2: > - rewrote to indicate MSI-X table entry index > v0->v1: > - added 'here' > - dropped 'receiving' > --- > transport-pci.tex | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/transport-pci.tex b/transport-pci.tex > index cf2c54d..afa082f 100644 > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport > A 0 means the queue is unavailable. > > \item[\field{queue_msix_vector}] > - The driver uses this to specify the queue vector for MSI-X. > + The driver writes the MSI-X table entry index in this field for > + virtqueue notification interrupts. same comment here > \item[\field{queue_enable}] > The driver uses this to selectively prevent the device from executing requests from this virtqueue. > -- > 2.26.2 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org