public inbox for virtio-dev@lists.linux.dev
 help / color / mirror / Atom feed
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
	<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
	Parav Pandit <parav@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] [PATCH 2/2] transport-pci: Improve queue msix vector register desc
Date: Thu, 20 Apr 2023 22:51:58 +0300	[thread overview]
Message-ID: <20230420195158.69737-3-parav@nvidia.com> (raw)
In-Reply-To: <20230420195158.69737-1-parav@nvidia.com>

queue_msix_vector register is for receiving virtqueue notification
interrupts from the device for the virtqueue.

"for MSI-X" is confusing term.

Also it is the register that driver "writes" to, similar to
many other registers such as queue_desc, queue_driver etc.

Hence, replace the verb from use to write.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
changelog:
v1->v2:
- rewrote to indicate MSI-X table entry index
v0->v1:
- added 'here'
- dropped 'receiving'
---
 transport-pci.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index cf2c54d..afa082f 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-        The driver uses this to specify the queue vector for MSI-X.
+        The driver writes the MSI-X table entry index in this field for
+        virtqueue notification interrupts.
 
 \item[\field{queue_enable}]
         The driver uses this to selectively prevent the device from executing requests from this virtqueue.
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-04-20 19:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20 19:51 [virtio-dev] [PATCH 0/2] transport-pci: msix register desc improve Parav Pandit
2023-04-20 19:51 ` [virtio-dev] [PATCH 1/2] transport-pci: Improve config msix vector description Parav Pandit
2023-04-20 20:44   ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-20 20:51     ` [virtio-dev] " Parav Pandit
2023-04-21  5:37       ` [virtio-dev] " Michael S. Tsirkin
2023-04-21  5:43       ` Michael S. Tsirkin
2023-04-20 19:51 ` Parav Pandit [this message]
2023-04-20 20:45   ` [virtio-dev] Re: [PATCH 2/2] transport-pci: Improve queue msix vector register desc Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2023-04-11 19:42 [virtio-dev] [PATCH 0/2] transport-pci: msix register desc improve Parav Pandit
2023-04-11 19:42 ` [virtio-dev] [PATCH 2/2] transport-pci: Improve queue msix vector register desc Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420195158.69737-3-parav@nvidia.com \
    --to=parav@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox