From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A058C7618E for ; Fri, 21 Apr 2023 05:37:43 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 7008D2AC56 for ; Fri, 21 Apr 2023 05:37:42 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 5BDD598664A for ; Fri, 21 Apr 2023 05:37:42 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 4F5DD986639; Fri, 21 Apr 2023 05:37:42 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 3B2EB986638 for ; Fri, 21 Apr 2023 05:37:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: xUAGoKqOPUKVTIraT7ox0w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682055457; x=1684647457; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rvj/tPDnWqWkpGKU+ZIAoggJv+IOb9ucBH1F/a6Fy4Q=; b=BfZklmvAaKhXUSriFH9DlcR7R3GnaJfbcXQEkCIFFGDqWeQC+yucsFRz8KRRcgHT70 3ivAq4q92drowQmG80xBEfU7UesxtLLbB6nMgMwyVVOsn4eRXLHkGO0/DBpqKJdpSG// gkoKHMSPjbgAoOTuSdUjkdQBX591B99ci7suoLxQ9ZT6RgjQdcMtPJKbNu4f8QKfnfCu xtOKxeSsVPLdBmpJs+LuiKJd9b+Jgks1wUE3ytMy+eChD87akMc+Q+IcvzeB3DbvYfrA HcfC0JFc2FeU42vwLfaZrHJqr5wSd4+CBzGzCpAm6r+vyx2EKkYlE54/rkX4eV7IuDOR KnBg== X-Gm-Message-State: AAQBX9eA+sJO3XWmZf1GE17fNYRpM3SiJKvshbjf/orpKZuidUJ7/pRZ 5iI8Dt2zrVrnGU9SScqYYOTSnGxhtYQvU3ubKJ35cUIZPMnjDLJ9v4r/ZsilyEleVfRxLHQDWSD iHR5YZvPWScBPUsfGwBfYoZ/fy0SI X-Received: by 2002:a7b:cb8a:0:b0:3ee:1acd:b039 with SMTP id m10-20020a7bcb8a000000b003ee1acdb039mr809215wmi.34.1682055456755; Thu, 20 Apr 2023 22:37:36 -0700 (PDT) X-Google-Smtp-Source: AKy350buTzx0O1X98KYm7vSu5ry1DUtKYa1L9y34HsuwHRZXkoXJBz76mKRgqRh9INZM4LcAB2Y1lA== X-Received: by 2002:a7b:cb8a:0:b0:3ee:1acd:b039 with SMTP id m10-20020a7bcb8a000000b003ee1acdb039mr809203wmi.34.1682055456499; Thu, 20 Apr 2023 22:37:36 -0700 (PDT) Date: Fri, 21 Apr 2023 01:37:32 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-dev@lists.oasis-open.org" , "pasic@linux.ibm.com" , "cohuck@redhat.com" , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler , Max Gurtovoy Message-ID: <20230421013005-mutt-send-email-mst@kernel.org> References: <20230420195158.69737-1-parav@nvidia.com> <20230420195158.69737-2-parav@nvidia.com> <20230420163800-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] [PATCH 1/2] transport-pci: Improve config msix vector description On Thu, Apr 20, 2023 at 08:51:57PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, April 20, 2023 4:45 PM > > > \item[\field{config_msix_vector}] > > > - The driver sets the Configuration Vector for MSI-X. > > > + The driver writes the MSI-X table entry index in this field for > > > + Configuration change notification interrupts. > > > > > > Urm not exactly. there is also a special value of 0xffff. > > I feel this here is just a high level description. > It is high-level description. 0xffff is already covered elsewhere in the doc. > > > how about > > Used by the driver to set the MSI-X vector for Configuration change > > notification interrupts. > > > > pci spec also calls the entry "the vector" so I feel it's ok. > > > > To keep the text consistent with rest of the fields, how about > > The driver writes the MSI-X table vector in this field for Configuration change notification interrupts. > It uses a single verb instead two = "used" and "set". well it's just "the MSI-X vector". not "table vector". and personally I'd like something less verbose. yes Configuration isn't really clear. and I dislike saying "this field" or "here" - it feels repetetive ... Set by the driver to the MSI-X Vector for Configuration change notifications. ? --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org