[virtio-dev] [PATCH v3 0/2] transport-pci: msix register desc improve

[virtio-dev] [PATCH v3 0/2] transport-pci: msix register desc improve

[Parav Pandit]

Problem:

Current wording queue_msix_vector and config_msix_vector says
"for MSI-X", which is bit confusing.

config_msix_vector and queue_msix_vector are the msix vector
number for configuration change and queue related interrupts.

Hence, reword it.

---
changelog:
v2->v3:
- reword
v1->v2:
- rewrote to indicate MSI-X table entry index
v0->v1:
- added 'here'
- dropped 'receiving'
- dropped already merged patch for empty line


Parav Pandit (2):
  transport-pci: Improve config msix vector description
  transport-pci: Improve queue msix vector register desc

 transport-pci.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] [PATCH v3 1/2] transport-pci: Improve config msix vector description

[Parav Pandit]

config_msix_vector is the register that holds the MSI-X vector number
for receiving configuration change related interrupts.

It is not "for MSI-X".

Hence, replace the confusing text with appropriate one.

Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>

---
changelog:
v2->v3:
- rewrite
v1->v2:
- rewrote to indicate MSI-X table entry index
v0->v1:
- added 'here'
- dropped 'receiving'
---
 transport-pci.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index 5d98467..396bef7 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -343,7 +343,7 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         Driver Feature Bits selected by \field{driver_feature_select}.
 
 \item[\field{config_msix_vector}]
-        The driver sets the Configuration Vector for MSI-X.
+        Set by the driver to the MSI-X vector for configuration change notifications.
 
 \item[\field{num_queues}]
         The device specifies the maximum number of virtqueues supported here.
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] [PATCH v3 2/2] transport-pci: Improve queue msix vector register desc

[Parav Pandit]

queue_msix_vector register is for receiving virtqueue notification
interrupts from the device for the virtqueue.

"for MSI-X" is confusing term.

Also it is the register that driver "writes" to, similar to
many other registers such as queue_desc, queue_driver etc.

Hence, replace the verb from use to write.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
changelog:
v2->v3:
- rewrite
v1->v2:
- rewrote to indicate MSI-X table entry index
v0->v1:
- added 'here'
- dropped 'receiving'
---
 transport-pci.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/transport-pci.tex b/transport-pci.tex
index 396bef7..524bfff 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -366,7 +366,7 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-        The driver uses this to specify the queue vector for MSI-X.
+        Set by the driver to the MSI-X vector for virtqueue notifications.
 
 \item[\field{queue_enable}]
         The driver uses this to selectively prevent the device from executing requests from this virtqueue.
-- 
2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3 0/2] transport-pci: msix register desc improve

[Michael S. Tsirkin]

On Fri, Apr 21, 2023 at 05:54:32PM +0300, Parav Pandit wrote:
> Problem:
> 
> Current wording queue_msix_vector and config_msix_vector says
> "for MSI-X", which is bit confusing.
> 
> config_msix_vector and queue_msix_vector are the msix vector
> number for configuration change and queue related interrupts.
> 
> Hence, reword it.

LGTM.
Given the amount of back and forth, I guess we should vote.

> ---
> changelog:
> v2->v3:
> - reword
> v1->v2:
> - rewrote to indicate MSI-X table entry index
> v0->v1:
> - added 'here'
> - dropped 'receiving'
> - dropped already merged patch for empty line
> 
> 
> Parav Pandit (2):
>   transport-pci: Improve config msix vector description
>   transport-pci: Improve queue msix vector register desc
> 
>  transport-pci.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] RE: [PATCH v3 0/2] transport-pci: msix register desc improve

[Parav Pandit]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Saturday, April 22, 2023 6:11 AM
> 
> On Fri, Apr 21, 2023 at 05:54:32PM +0300, Parav Pandit wrote:
> > Problem:
> >
> > Current wording queue_msix_vector and config_msix_vector says "for
> > MSI-X", which is bit confusing.
> >
> > config_msix_vector and queue_msix_vector are the msix vector number
> > for configuration change and queue related interrupts.
> >
> > Hence, reword it.
> 
> LGTM.
> Given the amount of back and forth, I guess we should vote.
> 
Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.

[1] https://github.com/oasis-tcs/virtio-spec/issues/169

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] RE: [PATCH v3 0/2] transport-pci: msix register desc improve

[Parav Pandit]

Hi,

> From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> open.org> On Behalf Of Parav Pandit
> Sent: Monday, April 24, 2023 11:15 AM

> > LGTM.
> > Given the amount of back and forth, I guess we should vote.
> >
> Ok. created github at [1].
> Will wait for few more days to ask for vote for any other review comments.
> 
> [1] https://github.com/oasis-tcs/virtio-spec/issues/169

Can you please raise the ballot for this?


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3 0/2] transport-pci: msix register desc improve

[Michael S. Tsirkin]

On Fri, Apr 28, 2023 at 04:10:21AM +0000, Parav Pandit wrote:
> Hi,
> 
> > From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> > open.org> On Behalf Of Parav Pandit
> > Sent: Monday, April 24, 2023 11:15 AM
> 
> > > LGTM.
> > > Given the amount of back and forth, I guess we should vote.
> > >
> > Ok. created github at [1].
> > Will wait for few more days to ask for vote for any other review comments.
> > 
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/169
> 
> Can you please raise the ballot for this?

ok if you put in link to lore, not to oasis archive, then
please also include date and subject so people can still locate
it in the oasis archive if they need to.

-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3 0/2] transport-pci: msix register desc improve

[Michael S. Tsirkin]

On Fri, Apr 28, 2023 at 12:46:13AM -0400, Michael S. Tsirkin wrote:
> On Fri, Apr 28, 2023 at 04:10:21AM +0000, Parav Pandit wrote:
> > Hi,
> > 
> > > From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> > > open.org> On Behalf Of Parav Pandit
> > > Sent: Monday, April 24, 2023 11:15 AM
> > 
> > > > LGTM.
> > > > Given the amount of back and forth, I guess we should vote.
> > > >
> > > Ok. created github at [1].
> > > Will wait for few more days to ask for vote for any other review comments.
> > > 
> > > [1] https://github.com/oasis-tcs/virtio-spec/issues/169
> > 
> > Can you please raise the ballot for this?
> 
> ok if you put in link to lore, not to oasis archive, then
> please also include date and subject so people can still locate
> it in the oasis archive if they need to.

Also please link to virtio-comment archive. virtio-dev is
for device/driver developers not for comments.

> -- 
> MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] RE: [PATCH v3 0/2] transport-pci: msix register desc improve

[Parav Pandit]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Friday, April 28, 2023 12:47 AM

> > > > [1] https://github.com/oasis-tcs/virtio-spec/issues/169
> > >
> > > Can you please raise the ballot for this?
> >
> > ok if you put in link to lore, not to oasis archive, then please also
> > include date and subject so people can still locate it in the oasis
> > archive if they need to.
> 
> Also please link to virtio-comment archive. virtio-dev is for device/driver
> developers not for comments.

Added OASIS virtio comment link.
Updated lore link to virtio-comment as well.

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] RE: [PATCH v3 0/2] transport-pci: msix register desc improve

[Parav Pandit]

> From: Parav Pandit <parav@nvidia.com>
> Sent: Friday, April 28, 2023 12:10 AM
> To: Parav Pandit <parav@nvidia.com>; Michael S. Tsirkin <mst@redhat.com>
> 
> Hi,
> 
> > From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> > open.org> On Behalf Of Parav Pandit
> > Sent: Monday, April 24, 2023 11:15 AM
> 
> > > LGTM.
> > > Given the amount of back and forth, I guess we should vote.
> > >
> > Ok. created github at [1].
> > Will wait for few more days to ask for vote for any other review comments.
> >
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/169
> 
> Can you please raise the ballot for this?
Can you please merge the patches in the tree?

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [virtio-comment] RE: [PATCH v3 0/2] transport-pci: msix register desc improve

[Michael S. Tsirkin]

On Fri, Apr 28, 2023 at 04:10:21AM +0000, Parav Pandit wrote:
> Hi,
> 
> > From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> > open.org> On Behalf Of Parav Pandit
> > Sent: Monday, April 24, 2023 11:15 AM
> 
> > > LGTM.
> > > Given the amount of back and forth, I guess we should vote.
> > >
> > Ok. created github at [1].
> > Will wait for few more days to ask for vote for any other review comments.
> > 
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/169
> 
> Can you please raise the ballot for this?

FWIW the proper format is

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/169

as documented in our README.md


> 
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
> 
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
> 
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org