[virtio-dev] Re: [virtio] Re: [virtio-comment] RE: [PATCH v11 02/10] admin: introduce device group and related concepts

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Apr 24, 2023 at 04:45:27PM +0000, Parav Pandit wrote:
> 
> > From: virtio@lists.oasis-open.org <virtio@lists.oasis-open.org> On Behalf Of
> > Michael S. Tsirkin
> > 
> > On Mon, Apr 10, 2023 at 04:42:42PM +0000, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin <mst@redhat.com>
> > > > Sent: Monday, April 10, 2023 9:24 AM
> > >
> > > > > From this point onward you can add,
> > > > > --- line. So that it doesnt go to the commit log.
> > > >
> > > > I can but motivation for design choices is a good thing to have in
> > > > the commit log.
> > > >
> > > Yes.
> > > Righting it as
> > > Usually, I see those design notes or rationale written as third person
> > sentences.
> > >
> > > Also, since those design choices are good to capture, can we start cover letter
> > commit also, which usually give a complete or broad view of the design?
> > 
> > too much beaurocracy really imho.
> > 
> Commit log is capturing the use case and other design aspects of the spec.
> I don't see it as bureaucracy.

Motivation is what we have in the cover.  Considerations that went into
specific design are really hard to capture, and we have enough trouble
adding things to spec without adding extra requirements from
contributors to justify each decision.

> You didn't get the answer when _CONFIG_DATA question arises in past.
> You also didn't get answer from other Intel engineer, which was unreachable, I forgot the issue.
> Cover letter will capture those.
> 
> If we prefer to not have cover letter, please move these details in the individual patch.
> Anyways you send out v12 so next work.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org