Re: [virtio-dev] [PATCH v15 01/11] content: Add vq index text

David Edmondson
2023-05-03T10:40:04Z

Parav Pandit <parav@nvidia.com> writes:

> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> changelog:
> v12->v13:
> - avoid virtqueue -> vq abbreviation
> - removed Cornelia's reviewed-by due to vq abbreviation change
> v11->v12:
> - renamed 'number' to 'index'
> v9->v10:
> - added braces around vq number wording
> - added vqn as another term for vq number
> v8->v9:
> - added inclusive when describing the vq number range
> - skipped comment to put virtqueue number wording first because we
> prefer to use shorter vq number as much as possible
> v5->v6:
> - moved description close to introduction, it was in middle of
> queue data transfer description
> v2->v3:
> - new patch
> ---
> content.tex | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index cff548a..43be58b 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -298,6 +298,9 @@ \section{Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Virtqueues}
> virtqueues\footnote{For example, the simplest network device has one virtqueue for
> transmit and one for receive.}.
>
> +Each virtqueue is identified by a virtqueue index; virtqueue index range is
> +from 0 to 65535 inclusive.
> +

The range is a property of the index, so generally we would say
"a virtqueue index's range", but that feels a bit odd.

How about avoiding the problem with something like "virtqueue indexes
range from 0 to 65535 inclusive".

> Driver makes requests available to device by adding
> an available buffer to the queue, i.e., adding a buffer
> describing the request to a virtqueue, and optionally triggering
> --
> 2.26.2
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
--
You know your green from your red.