From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <cohuck@redhat.com>
Cc: <sgarzare@redhat.com>, <pasic@linux.ibm.com>,
<virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v15 07/11] transport-ccw: Rename queue depth/size to other transports
Date: Fri, 28 Apr 2023 07:19:45 +0300 [thread overview]
Message-ID: <20230428041949.411221-8-parav@nvidia.com> (raw)
In-Reply-To: <20230428041949.411221-1-parav@nvidia.com>
max_num field reflects the maximum queue size/depth. Hence align name of
this field with similar field in PCI and MMIO transport to
max_queue_size.
Similarly rename 'num' to 'size'.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v9>v10:
- used lower case letter for comment first word
v8->v9:
- replaced 'named' as 'known'
v3->v4:
- moved note to comment
---
transport-ccw.tex | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/transport-ccw.tex b/transport-ccw.tex
index c492cb9..cb476c7 100644
--- a/transport-ccw.tex
+++ b/transport-ccw.tex
@@ -237,12 +237,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\begin{lstlisting}
struct vq_config_block {
be16 index;
- be16 max_num;
+ be16 max_queue_size; /* previously known as max_num */
};
\end{lstlisting}
The requested number of buffers for queue \field{index} is returned in
-\field{max_num}.
+\field{max_queue_size}.
Afterwards, CCW_CMD_SET_VQ is issued by the driver to inform the
device about the location used for its queue. The transmitted
@@ -253,7 +253,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
be64 desc;
be32 res0;
be16 index;
- be16 num;
+ be16 size; /* previously known as num */
be64 driver;
be64 device;
};
@@ -262,7 +262,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\field{desc}, \field{driver} and \field{device} contain the guest
addresses for the descriptor area,
available area and used area for queue \field{index}, respectively. The actual
-virtqueue size (number of allocated buffers) is transmitted in \field{num}.
+virtqueue size (number of allocated buffers) is transmitted in \field{size}.
\devicenormative{\paragraph}{Configuring a Virtqueue}{Virtio Transport Options / Virtio over channel I/O / Device Initialization / Configuring a Virtqueue}
@@ -278,11 +278,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
be64 queue;
be32 align;
be16 index;
- be16 num;
+ be16 size; /* previously known as num */
};
\end{lstlisting}
-\field{queue} contains the guest address for queue \field{index}, \field{num} the number of buffers
+\field{queue} contains the guest address for queue \field{index},
+\field{size} the number of buffers
and \field{align} the alignment. The queue layout follows \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}.
\subsubsection{Communicating Status Information}\label{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Communicating Status Information}
--
2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-28 4:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 4:19 [virtio-dev] [PATCH v15 00/11] Rename queue number to queue index Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 01/11] content: Add vq index text Parav Pandit
2023-05-03 10:34 ` David Edmondson
2023-05-03 21:09 ` Parav Pandit
2023-05-03 21:45 ` David Edmondson
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 02/11] content.tex Replace virtqueue number with index Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 03/11] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-05-03 10:48 ` [virtio-dev] Re: [virtio-comment] " David Edmondson
2023-05-03 20:05 ` [virtio-dev] " Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 04/11] transport-pci: Avoid first vq index reference Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 05/11] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 06/11] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-28 4:19 ` Parav Pandit [this message]
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 08/11] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 09/11] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 10/11] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-05-03 15:57 ` [virtio-dev] Re: [virtio-comment] " David Edmondson
2023-05-03 20:07 ` [virtio-dev] " Parav Pandit
2023-04-28 4:19 ` [virtio-dev] [PATCH v15 11/11] virtio-net: Update vqn to vq_index for cvq cmds Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428041949.411221-8-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox