[virtio-dev] RE: [PATCH 0/2] admin virtqueue fixes

Parav Pandit
2023-05-02T11:35:25Z

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Tuesday, May 2, 2023 3:42 AM
>
> On Tue, May 02, 2023 at 01:44:28AM +0300, Parav Pandit wrote:
> >
> > Hi Michael,
> >
> > Please review these two small fixes for the admin virtqueue patches.
> > They are on top of your work of v12 at [1].
> >
> > Patch summary:
> > patch-1 removes PCI transport dependency on deprecated migration bit
> > patch-2 fixes admin command command data type to be u8 similar to
> > result
> >
> > [1]
> > https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat
> > .com/T/#t
>
> I can take 1/2 since that's just removing text. Taking 2/2 will mean more review
> time before vote - besides me not really liking that change, are you sure it's
> worth it?
> Was going to start voting today but if we are still tweaking command format
> then I can't ...
>
There were 4 editorial fixes without which PDF is not readable for v12 and commit message needs update the AQ usage.
It needs rebase also.
And these two changes also.

Given we have 6+ changes, better to make them and ask for vote after that.

Vote includes spec and commit message content.
So please roll v13 addressing above to make things easier to vote.

You said posting too fast is not good. Now one week has passed, so its fine to repost v13 and ask for the vote.