[virtio-dev] Re: [PATCH 0/2] admin virtqueue fixes

Michael S. Tsirkin
2023-05-02T07:41:47Z

On Tue, May 02, 2023 at 01:44:28AM +0300, Parav Pandit wrote:
>
> Hi Michael,
>
> Please review these two small fixes for the admin virtqueue patches.
> They are on top of your work of v12 at [1].
>
> Patch summary:
> patch-1 removes PCI transport dependency on deprecated migration bit
> patch-2 fixes admin command command data type to be u8 similar to result
>
> [1] https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat.com/T/#t

I can take 1/2 since that's just removing text. Taking 2/2 will mean
more review time before vote - besides me not really
liking that change, are you sure it's worth it?
Was going to start voting today but if we are still
tweaking command format then I can't ...

> Parav Pandit (2):
> admin: Remove dependency on the deprecated register
> admin: Make optional command data type to u8
>
> admin.tex | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> --
> 2.26.2