[virtio-dev] Re: [PATCH 1/2] admin: Remove dependency on the deprecated register

Michael S. Tsirkin
2023-05-02T07:39:52Z

On Tue, May 02, 2023 at 01:44:29AM +0300, Parav Pandit wrote:
> 'VF Migration Capable' is already deprecated as per
> PCI base specification 6.0.1 section 9.3.3.2.1.
> It was long ago deprecated which was meant for MR-IOV.
>
> Hence, remove virtio PCI specification to not depend
> on such deprecated bits.
>
> This patch is on top of [1].
>
> [1] https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat.com/T/#t
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

OK you know best I guess. I will drop mentions of VF Migration Capable.

> ---
> admin.tex | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/admin.tex b/admin.tex
> index 2efd4d7..037e2e6 100644
> --- a/admin.tex
> +++ b/admin.tex
> @@ -372,9 +372,8 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> \field{status} set to VIRTIO_ADMIN_STATUS_EINVAL and
> \field{status_qualifier} set to
> VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER;
> -\field{NumVFs}, \field{VF Migration Capable} and
> -\field{VF Enable} refer to registers within the SR-IOV Extended
> -Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
> +\field{NumVFs} and \field{VF Enable} refer to registers within the
> +SR-IOV Extended Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
>
> \drivernormative{\paragraph}{Group administration commands}{Basic Facilities of a Virtio Device / Device groups / Group administration commands}
>
> @@ -423,11 +422,9 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> the driver specify a value for \field{group_member_id}
> between $1$ and \field{NumVFs} inclusive,
> the driver MUST also make sure that as long as any such command
> -is outstanding, \field{VF Migration Capable} is clear and
> -\field{VF Enable} is set;
> -\field{NumVFs}, \field{VF Migration Capable} and
> -\field{VF Enable} refer to registers within the SR-IOV Extended
> -Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
> +is outstanding, is clear and \field{VF Enable} is set;
> +\field{NumVFs} and \field{VF Enable} refer to registers within the
> +SR-IOV Extended Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
>
> \section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Administration Virtqueues}
>
> --
> 2.26.2