From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH 0/2] admin virtqueue fixes
Date: Tue, 2 May 2023 03:41:36 -0400 [thread overview]
Message-ID: <20230502033954-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230501224430.485139-1-parav@nvidia.com>
On Tue, May 02, 2023 at 01:44:28AM +0300, Parav Pandit wrote:
>
> Hi Michael,
>
> Please review these two small fixes for the admin virtqueue patches.
> They are on top of your work of v12 at [1].
>
> Patch summary:
> patch-1 removes PCI transport dependency on deprecated migration bit
> patch-2 fixes admin command command data type to be u8 similar to result
>
> [1] https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat.com/T/#t
I can take 1/2 since that's just removing text. Taking 2/2 will mean
more review time before vote - besides me not really
liking that change, are you sure it's worth it?
Was going to start voting today but if we are still
tweaking command format then I can't ...
> Parav Pandit (2):
> admin: Remove dependency on the deprecated register
> admin: Make optional command data type to u8
>
> admin.tex | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> --
> 2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-05-02 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 22:44 [virtio-dev] [PATCH 0/2] admin virtqueue fixes Parav Pandit
2023-05-01 22:44 ` [virtio-dev] [PATCH 1/2] admin: Remove dependency on the deprecated register Parav Pandit
2023-05-02 7:39 ` [virtio-dev] " Michael S. Tsirkin
2023-05-01 22:44 ` [virtio-dev] [PATCH 2/2] admin: Make optional command data type to u8 Parav Pandit
2023-05-02 7:37 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 11:29 ` [virtio-dev] " Parav Pandit
2023-05-02 11:36 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 7:41 ` Michael S. Tsirkin [this message]
2023-05-02 11:34 ` [virtio-dev] RE: [PATCH 0/2] admin virtqueue fixes Parav Pandit
2023-05-02 11:40 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502033954-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox