[virtio-dev] Re: [PATCH v16 04/11] transport-pci: Avoid first vq index reference

David Edmondson
2023-05-04T14:28:44Z

Parav Pandit <parav@nvidia.com> writes:

> Drop reference to first virtqueue as it is already
> covered now by the generic section in first patch.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Acked-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
> changelog:
> v11->v12:
> - drop changes related to vq number
> v9->v10:
> - updated commit log to drop reference to old patch
> v8->v9:
> - reword the sentence to avoid future tense, like rest of the other
> fields description
> - reword the sentence to avoid multiple verbs use and put -> uses
> - use shorter name 'vq number' instead of 'virtqueue number'
> v7->v8:
> - remove note about first virtqueue number
> - skipped Max's comment to put word 'structure' in same line as its
> crosses 65 chars limit per line
> - reworded queue_notification data set line, as '=' and vq number
> wording was odd
> v2->v3:
> - addressed comments from Michael
> - changed vqn to virtqueue number in the Note
> - refer to vqn field instead of virtqueue number
> ---
> transport-pci.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport-pci.tex b/transport-pci.tex
> index aa9842f..cfe3fe2 100644
> --- a/transport-pci.tex
> +++ b/transport-pci.tex
> @@ -1011,7 +1011,7 @@ \subsubsection{Device Initialization}\label{sec:Virtio Transport Options / Virti
> The driver typically does this as follows, for each virtqueue a device has:
>
> \begin{enumerate}
> -\item Write the virtqueue index (first queue is 0) to \field{queue_select}.
> +\item Write the virtqueue index to \field{queue_select}.
>
> \item Read the virtqueue size from \field{queue_size}. This controls how big the virtqueue is
> (see \ref{sec:Basic Facilities of a Virtio Device / Virtqueues}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues}). If this field is 0, the virtqueue does not exist.
> --
> 2.26.2
--
I'm in a backless dress on a pastel ward that's shining.