From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <cohuck@redhat.com>
Cc: <sgarzare@redhat.com>, <pasic@linux.ibm.com>,
<david.edmondson@oracle.com>,
<virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v16 09/11] virtio-net: Avoid duplicate receive queue example
Date: Thu, 4 May 2023 05:29:57 +0300 [thread overview]
Message-ID: <20230504022959.547025-10-parav@nvidia.com> (raw)
In-Reply-To: <20230504022959.547025-1-parav@nvidia.com>
Receive queue number/index example is duplicate which is already defined
in the Setting RSS parameters section.
Hence, avoid such duplicate example and prepare it for the subsequent
patch to describe using receive queue handle.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
device-types/net/description.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index 875c4e6..f3f9f1d 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -1478,8 +1478,8 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
The device MUST determine the destination queue for a network packet as follows:
\begin{itemize}
\item Calculate the hash of the packet as defined in \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets}.
-\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure (value of 0 corresponds to receiveq1).
-\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq (value of 0 corresponds to receiveq1).
+\item If the device did not calculate the hash for the specific packet, the device directs the packet to the receiveq specified by \field{unclassified_queue} of virtio_net_rss_config structure.
+\item Apply \field{indirection_table_mask} to the calculated hash and use the result as the index in the indirection table to get 0-based number of destination receiveq.
\item If the destination receive queue is being reset (See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device MUST drop the packet.
\end{itemize}
--
2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-05-04 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 2:29 [virtio-dev] [PATCH v16 00/11] Rename queue number to queue index Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 01/11] content: Add vq index text Parav Pandit
2023-05-04 14:20 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 02/11] content.tex Replace virtqueue number with index Parav Pandit
2023-05-04 14:20 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 03/11] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-05-04 14:28 ` [virtio-dev] " David Edmondson
2023-05-04 18:33 ` [virtio-dev] " Parav Pandit
2023-05-04 18:49 ` [virtio-dev] " Michael S. Tsirkin
2023-05-04 19:00 ` [virtio-dev] " Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 04/11] transport-pci: Avoid first vq index reference Parav Pandit
2023-05-04 14:28 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 05/11] transport-mmio: Rename QueueNum register Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 06/11] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-05-04 14:29 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 07/11] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 08/11] transport-ccw: Refer to the vq by its index Parav Pandit
2023-05-04 2:29 ` Parav Pandit [this message]
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 10/11] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-05-04 14:30 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 11/11] virtio-net: Update vqn to vq_index for cvq cmds Parav Pandit
2023-05-04 14:31 ` [virtio-dev] " David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504022959.547025-10-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox