[virtio-dev] Re: [PATCH v16 01/11] content: Add vq index text

David Edmondson
2023-05-04T14:25:30Z

Parav Pandit <parav@nvidia.com> writes:

> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
> changelog:
> v15->v16:
> - rewrote for better reading
> v12->v13:
> - avoid virtqueue -> vq abbreviation
> - removed Cornelia's reviewed-by due to vq abbreviation change
> v11->v12:
> - renamed 'number' to 'index'
> v9->v10:
> - added braces around vq number wording
> - added vqn as another term for vq number
> v8->v9:
> - added inclusive when describing the vq number range
> - skipped comment to put virtqueue number wording first because we
> prefer to use shorter vq number as much as possible
> v5->v6:
> - moved description close to introduction, it was in middle of
> queue data transfer description
> v2->v3:
> - new patch
> ---
> content.tex | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index cff548a..9b694f2 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -298,6 +298,10 @@ \section{Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Virtqueues}
> virtqueues\footnote{For example, the simplest network device has one virtqueue for
> transmit and one for receive.}.
>
> +A virtio device can have maximum of 65536 virtqueues. Each virtqueue is
> +identified by a virtqueue index. A virtqueue index has a value in the
> +range of 0 to 65535.
> +
> Driver makes requests available to device by adding
> an available buffer to the queue, i.e., adding a buffer
> describing the request to a virtqueue, and optionally triggering
> --
> 2.26.2
--
Walking upside down in the sky, between the satellites passing by, I'm looking.